calc.php: escape % in code before logging

so sprintf in logEval won't break (php8) with' x arguments required, y given'
Fabrik · Feb 22, 2023 · f051859 · f051859
1 parent e218990
commit f051859
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/plugins/fabrik_element/calc/calc.php b/plugins/fabrik_element/calc/calc.php
@@ -47,7 +47,7 @@ public function getDefaultValue($data = array())
 				{
 					$res = @eval($default);
 				}
-				FabrikWorker::logEval($res, 'Eval exception : ' . $element->name . '::getDefaultValue() : ' . $default . ' : %s');
+				FabrikWorker::logEval($res, 'Eval exception : ' . $element->name . '::getDefaultValue() : ' . str_replace('%','%%',$default) . ' : %s');
 				$default = $res;
 			}
 			*/
@@ -103,7 +103,7 @@ private function _getV($data, $repeatCounter)
 			$d = $data;
 			FabrikWorker::clearEval();
 			$res = FabrikHelperHTML::isDebug() ? eval($default) : @eval($default);
-			FabrikWorker::logEval($res, 'Eval exception : ' . $this->getElement()->name . ' (id ' . $this->getId() . ')::_getV() : ' . $default . ' : %s');
+			FabrikWorker::logEval($res, 'Eval exception : ' . $this->getElement()->name . ' (id ' . $this->getId() . ')::_getV() : ' . str_replace('%','%%',$default) . ' : %s');
 
 			return $res;
 		}
@@ -319,7 +319,7 @@ public function preFormatFormJoins($data, $row)
 				$res = @eval($cal);
 			}
 
-			FabrikWorker::logEval($res, 'Eval exception : ' . $element->name . ' (id ' . $this->getId() . ')::preFormatFormJoins() : ' . $cal . ' : %s');
+			FabrikWorker::logEval($res, 'Eval exception : ' . $element->name . ' (id ' . $this->getId() . ')::preFormatFormJoins() : ' . str_replace('%','%%',$cal) . ' : %s');
 
 			$res = $this->getFormattedValue($res);