Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content Plugin - Layout not applied for second list #393

Closed
felixkat opened this issue Aug 2, 2012 · 19 comments
Closed

Content Plugin - Layout not applied for second list #393

felixkat opened this issue Aug 2, 2012 · 19 comments
Assignees
Milestone

Comments

@felixkat
Copy link

felixkat commented Aug 2, 2012

{fabrik view=list id=42 layout=bluesky}

{fabrik view=list id=42 layout=default}

The above will display both as bluesky.

@felixkat
Copy link
Author

felixkat commented Aug 2, 2012

I had a dig around but couldn't work out where it's not picking up the second value, (i.e the 2nd template value).

Only the bluesky CSS loads, so it's not a case of one overriding the other.

I need to check also if this is a issue loading the same list id twice opposed to two seperate lists.

@cheesegrits
Copy link
Member

Don't have anything to say, just testing something from my Android tablet.

@felixkat
Copy link
Author

felixkat commented Aug 3, 2012

New toys huh? Geek! Lol ;)

-----Original Message-----
From: Hugh Messenger [mailto:reply@reply.github.com]
Sent: 03 August 2012 06:54
To: felixkat
Subject: Re: [fabrik] Content Plugin - Layout not applied for second list (#393)

Don't have anything to say, just testing something from my Android tablet.


Reply to this email directly or view it on GitHub:
#393 (comment)

@cheesegrits
Copy link
Member

:)
On Aug 3, 2012 10:47 AM, "felixkat" <
reply@reply.github.com>
wrote:

New toys huh? Geek! Lol ;)

-----Original Message-----
From: Hugh Messenger [mailto:reply@reply.github.com]
Sent: 03 August 2012 06:54
To: felixkat
Subject: Re: [fabrik] Content Plugin - Layout not applied for second list
(#393)

Don't have anything to say, just testing something from my Android tablet.


Reply to this email directly or view it on GitHub:
#393 (comment)


Reply to this email directly or view it on GitHub:
#393 (comment)

@trob
Copy link

trob commented Aug 4, 2012

It's only loading the first template, seems to be ok for different lists.

But I think there's a general problem:
displaying lists/forms via content plugin or module plugin may create HTML objects with an identical id

@pollen8
Copy link
Member

pollen8 commented Aug 7, 2012

guess we need to add to the list/form's "render context" variable the order the list is in the number of plugins rendering on the page.
So yes trob you're correct this is a general problem where we currently will have lists/forms with idential ids

@ghost ghost assigned pollen8 Aug 16, 2012
@tutuxe
Copy link

tutuxe commented Jul 2, 2013

and it's the same if we duplicate one list with 2 different ID..... :( have you find an issue ? i 'm afraid that i will abandon Fabrik for that.... :(

@cheesegrits
Copy link
Member

I'll take a look at this now. I'm very surprised it won't work with a copy
of the list with a different ID ...

-- hugh

On Tue, Jul 2, 2013 at 4:34 PM, tutuxe notifications@github.com wrote:

and it's the same if we duplicate one list with 2 different ID..... :(
have you find an issue ? i 'm afraid that i will abandon Fabrik for
that.... :(


Reply to this email directly or view it on GitHubhttps://github.com//issues/393#issuecomment-20378994
.

@tutuxe
Copy link

tutuxe commented Jul 2, 2013

oh... hi :) .... i search it since a long time :) thank you very much for your searching.... it will be a real dream for me to get the issue.... :)

@cheesegrits
Copy link
Member

Works for me using a copy of the list, hence two different ID's, with two different layouts. Here's a quick video showing it working:

http://screencast.com/t/BHpLRKpqMRL

Suggest you try updating from github and running the latest code. If it's been a while since you updated, obviously make a full backup before updating.

@tutuxe
Copy link

tutuxe commented Jul 3, 2013

Hi, thank for the anwer... ok i have the lastest code now.... something unexpected :
{fabrik view=list id=1 layout=default}
{fabrik view=list id=2 layout=div}
the layout is different, but the layout "div" takes the "mytemplate" default_row file where i put a limited caracters number...
So i really don't understand why all are mixed....

@cheesegrits
Copy link
Member

Not sure what you mean by "takes the "mytemplate" default_row file".

You should probably start a thread on the forums, with a link to this
issue, so we can discuss at more length. We try and keep these github
issue discussion to be specific to the actual code in proposed fixes, etc.

On Wed, Jul 3, 2013 at 1:59 AM, tutuxe notifications@github.com wrote:

Hi, thank for the anwer... ok i have the lastest code now.... something
unexpected :
{fabrik view=list id=1 layout=default}
{fabrik view=list id=2 layout=div}

the layout is different, but the layout "div" takes the "mytemplate"
default_row file where i put a limited caracters number...
So i really don't understand why all are mixed....


Reply to this email directly or view it on GitHubhttps://github.com//issues/393#issuecomment-20398781
.

@tutuxe
Copy link

tutuxe commented Jul 3, 2013

ok i do this :)

@tutuxe
Copy link

tutuxe commented Jul 3, 2013

oups... i can't open it....

i explained that i have 3 templates :

  • the regular "div" template
  • the regular "default" template
  • and a customized "mytemplate"

and when i do :

{fabrik view=list id=1 layout=default}
{fabrik view=list id=2 layout=div}

the both use the "mytemplate" file call : default_row

@tutuxe
Copy link

tutuxe commented Jul 3, 2013

ok I understood... in fact the problem comes from custom_css and template_css.
For a list A and a B where B is a copy from A, the name elements are the same, and the template files can't attibute two differents css in a same page...
Have you got an issue ? sorry to write again but i pass all my days on it to find an issue..
best regards

@trob
Copy link

trob commented Jul 3, 2013

On my site it's loading all CSS files from both templates.
In your CSS definitions you have to make sure to include the id
#listform_$c .your-class {}

Why can't you open a forum thread? Create a fabrik account, log in, post in communita forum.

@tutuxe
Copy link

tutuxe commented Jul 3, 2013

@trob trob closed this as completed Jul 5, 2013
@trob trob reopened this Jul 5, 2013
@trob
Copy link

trob commented Jul 5, 2013

Two layouts with different lists is ok.
Remaining issue: content plugin displaying the same list/form twice will create identical HTML ids.

@pollen8
Copy link
Member

pollen8 commented May 6, 2016

really dont think we can do anything about that - closing this ticket

@pollen8 pollen8 closed this as completed May 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants