Fix list view icons with custom links #2026
Conversation
|
At first sight the code looks good. Can you post before and after screen shots and HTML as before? |
|
The screen shots are identical in either case, what is critical is the underlying html. Here is the html before the change: |
|
That looks cool. Not sure when Hugh will be able to merge it into the main Fabrik code. |
|
It's merged in my local test branch, I'll merge it to master when I've finished testing. |
|
Hugh, can we get this merged so I can move on with my project? |
| $a = $html->getElementsByTagName('a')->item(0); | ||
| $img = $html->getElementsByTagName('img')->item(0); | ||
| if (isset($html) && isset($a) && isset($img)) | ||
| $isIcon = TRUE; |
There was a problem hiding this comment.
Put {} around the body. I know it's not technically required for a single statement.
|
|
||
| $paths = array( | ||
| COM_FABRIK_FRONTEND . '/views/list/tmpl/' . $this->getTmpl() . '/layouts/element/' . $elementModel->getFullName(true, false) | ||
| ); | ||
|
|
||
| $layout = $this->getLayout('element.fabrik-element-custom-link', $paths); | ||
| $layout = $isIcon ? $this->getLayout('element.fabrik-element-custom-icon-link', $paths) : $this->getLayout('element.fabrik-element-custom-link', $paths); |
There was a problem hiding this comment.
Avoid long lines, or PHP Storm will perpetually bitch at me about it. So only use inline condition for short stuff. Put this in a normal if/else.
| @@ -2320,12 +2320,23 @@ public function _addLink($data, &$elementModel, $row, $repeatCounter = 0) | |||
| $rowId = $this->getSlug($row); | |||
| $isAjax = $this->isAjaxLinks() ? '1' : '0'; | |||
| $isCustom = $customLink !== ''; | |||
| $isIcon = FALSE; | |||
| $a = $html->getElementsByTagName('a')->item(0); | ||
| $img = $html->getElementsByTagName('img')->item(0); | ||
| if (isset($html) && isset($a) && isset($img)) | ||
| $isIcon = TRUE; |
Created a new layout combining the custom links with the listicon-tips for the case of a custom link attached to an icon. See http://fabrikar.com/forums/index.php?threads/icon-link-in-list-to-custom-php-script.48785/ for details