Fix onDeleteRows for php 7 #2063
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was failing under php v.7. I hope the fix (adding {} brackets around variable used as object name) doe not break code for php less that v.7.
There is no need to run query if databasejoin element is empty (nothing selected) - was returning WHERE id IN("")
Just delete based on parent_id (__pk_val) instead of building array of selected values
|
Have you tested this with deleting more than one row? Seems like you'd need to create an array of pkvals from the selected rows, and delete IN($pkvals). |
This works for multiple deletes. This function gets called for every databasejoin element in the deleted row(s). It simply gets the PK value(s) of each deleted row and then deletes all records in that table_repeat_element table that has the PK value(s). I have no idea how this would work with databasejoin elements in joined tables or joined tables with repeat rows.
|
This works ONLY if no joined tables |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was failing under php v.7. I hope the fix (adding {} brackets around variable used as object name) doe not break code for php less that v.7.
There is no need to run query if databasejoin element is empty (nothing selected) - was returning WHERE id IN("")
Just delete based on parent_id (__pk_val) instead of building array of selected values