Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add group operation #17

Merged

Conversation

Kalzem
Copy link

@Kalzem Kalzem commented Feb 8, 2019

#14

This PR introduces the class GroupOperation which can include a few ConcurrentOperations that will run in parallel. Each ConcurrentOperation is responsible for it failures and retries. Doing so doesn't change Queuer's logic at all.

Allows for such flows: 1 -> [2A || 2B || 2C] -> 3

New GroupOperation concept
@Kalzem
Copy link
Author

Kalzem commented Feb 8, 2019

It's strange that Travis failed because of gem ?

@coveralls
Copy link

coveralls commented Feb 8, 2019

Pull Request Test Coverage Report for Build 447

  • 13 of 14 (92.86%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 96.957%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Sources/Queuer/GroupOperation.swift 13 14 92.86%
Totals Coverage Status
Change from base Build 430: -0.3%
Covered Lines: 223
Relevant Lines: 230

💛 - Coveralls

@FabrizioBrancati
Copy link
Owner

I restarted the job, but on Linux, the tests don't want to pass

@FabrizioBrancati
Copy link
Owner

All tests succeded 🎉

@FabrizioBrancati FabrizioBrancati merged commit d0686f0 into FabrizioBrancati:develop Jul 6, 2020
@FabrizioBrancati FabrizioBrancati mentioned this pull request Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants