Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parameter names / value? #16

Closed
tdhock opened this issue Aug 24, 2022 · 1 comment · Fixed by #18
Closed

parameter names / value? #16

tdhock opened this issue Aug 24, 2022 · 1 comment · Fixed by #18

Comments

@tdhock
Copy link
Collaborator

tdhock commented Aug 24, 2022

Are single quotes required for values in yaml? Would be nice to remove them. Also can we change time_limit to time_limit_seconds for clarity? like below

      - uses: FabrizioSandri/RcppDeepState-action@main
        with:
          fail_ci_if_error: true
          seed: 5
          time_limit_seconds: 60
          max_inputs: 100
          comment: true
          verbose: true
@FabrizioSandri FabrizioSandri mentioned this issue Aug 26, 2022
Merged
@FabrizioSandri
Copy link
Owner

Solved with pull request #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Parameters names/values FabrizioSandri/RcppDeepState-action
2 participants
@tdhock @FabrizioSandri