Parameters names/values

[FabrizioSandri]

The changes made in this pull request amount to:

• change the name of the time_limit parameter to max_seconds_per_function;
• check whether single quotes are required for parameters like booleans and integers inside workflow files;
• solve the problem that cause the action's log to include a warning message: rm: missing operand;
• solve the issue that cause a duplicate concatenation of the src path in the hyperlinks of the comment;
• strengthened the tests on NA values to avoid unexpected errors.

Fixes #16

[github-actions]

RcppDeepState Report

function name	message	file line	address trace	R code
rcpp_read_out_of_bound	Invalid read of size 4	read_out_of_bound.cpp:7	No Address Trace found	Test code testlist <- list(rbound = -1203971441L) result <- do.call(testSAN:::rcpp_read_out_of_bound, testlist)
rcpp_use_after_deallocate	Argument 'size' of function __builtin_vec_new has a fishy (possibly negative) value: -1203971441	use_after_deallocate.cpp:6	No Address Trace found	Test code testlist <- list(array_size = -1203971441L) result <- do.call(testSAN:::rcpp_use_after_deallocate, testlist)
rcpp_use_after_free	Argument 'size' of function malloc has a fishy (possibly negative) value: -4815885764	use_after_free.cpp:6	No Address Trace found	Test code testlist <- list(alloc_size = -1203971441L) result <- do.call(testSAN:::rcpp_use_after_free, testlist)
rcpp_write_index_outofbound	Invalid write of size 4	write_index_outofbound.cpp:8	No Address Trace found	Test code testlist <- list(wbound = -1203971441L) result <- do.call(testSAN:::rcpp_write_index_outofbound, testlist)
rcpp_zero_sized_array	Invalid write of size 4	zero_sized_array.cpp:8	zero_sized_array.cpp:7	Test code testlist <- list(value = -1203971441L) result <- do.call(testSAN:::rcpp_zero_sized_array, testlist)

Analyzed functions summary

function name	tested inputs	inputs with issues
rcpp_read_out_of_bound	3	3
rcpp_use_after_deallocate	3	3
rcpp_use_after_free	3	3
rcpp_use_uninitialized	3	0
rcpp_write_index_outofbound	3	3
rcpp_zero_sized_array	3	3

Report details

• Report generated by: f6b40ab
• Inputs generator seed: 5

[tdhock]

looks good, thanks!

[tdhock]

this is the duration for every input or for every function? maybe could be further clarified by changing the name to something like max_seconds_per_function ?

[FabrizioSandri]

I agree with you; this makes it clearer for the end user the purpose of the parameter.
Updated with commit aba09b7

[tdhock]

for every function

[FabrizioSandri]

Updated the README with commit aba09b7

[FabrizioSandri]

@tdhock, I removed the single quotes from the list of arguments in the workflow file that tests the RcppDeepState-action and discovered that everything still works perfectly without them. I will update the README file to remove the unnecessary quotes.

Tested with commit afd0b37

[FabrizioSandri]

I updated the workflow files and the README with the most recent commits, as indicated beforehand.

[FabrizioSandri]

With the second most recent commits, I fixed the problem that caused the action's log to include the following warning message:

rm: missing operand
Try 'rm --help' for more information.

This is because before running the xargs command in a pipe, it is necessary to verify if the command on the left side of the pipe succeeded. This is the man page of xargs:

-r, --no-run-if-empty
              If the standard input does not contain any nonblanks, do not run
              the command.  Normally, the command is run once even if there is
              no input.  This option is a GNU extension.

[FabrizioSandri]

The src prefix may already be present in the file line reference, which might lead to a duplicate concatenation of the src path in the hyperlinks of the comment. To address this I included the usage of the basename function in order to delete all of the path up to and including the last path separator.

[FabrizioSandri]

With the most recent changes, I strengthened the tests on NA values to avoid unexpected errors. For instance, prior to this update, it was possible for the address trace column to include a value of NA, which would result in the failure of the whole script.

[tdhock]

looks great, please merge if you like.