Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some mods may not have MMH description #419

Open
2 tasks
Madis0 opened this issue Jul 23, 2022 · 7 comments
Open
2 tasks

Some mods may not have MMH description #419

Madis0 opened this issue Jul 23, 2022 · 7 comments
Labels
bug Something isn't working

Comments

@Madis0
Copy link
Member

Madis0 commented Jul 23, 2022

Describe the bug

More Culling does not show a custom description by Mod Menu Helper, despite it being included in the file.

Screenshot_20220723_103952

Edit: as of 4.1.0-beta.1, it affects AdvancementInfo instead.

Modpack version

4.0.0-beta.11

Launcher

CurseForge Launcher

Other things

  • I updated FO to a newer version (mention, what version to what version)
  • I added/removed some mods or resource packs (mention, which ones)

Additional context

This is because the mod somehow applies its translated description after the Mod Menu Helper resource pack, or the resource pack just fails to overwrite it.

Relevant things that may help:

https://minecraft.fandom.com/wiki/Java_Edition_22w11a#General
https://misode.github.io/pack-mcmeta/

@Madis0 Madis0 added the bug Something isn't working label Jul 23, 2022
@Madis0

This comment was marked as resolved.

@Madis0 Madis0 added this to In progress in 1.19.2 Jul 23, 2022
@Madis0

This comment was marked as outdated.

@Madis0 Madis0 closed this as completed Jul 28, 2022
1.19.2 automation moved this from In progress to Done Jul 28, 2022
@Madis0
Copy link
Member Author

Madis0 commented Aug 1, 2022

The issue appears again with 4.1.0-beta.1 and AdvancementInfo. A fix has been suggested for Mod Menu. TerraformersMC/ModMenu#480

@Madis0 Madis0 reopened this Aug 1, 2022
1.19.2 automation moved this from Done to In progress Aug 1, 2022
@Madis0 Madis0 changed the title More Culling has no MMH description Some mods may not have MMH description Aug 1, 2022
@Madis0 Madis0 removed this from In progress in 1.19.2 Aug 1, 2022
@Madis0
Copy link
Member Author

Madis0 commented Aug 15, 2022

Turns out that LanguageReload also has a string of this kind, but MMH somehow still manages to override it... https://github.com/Jerozgen/LanguageReload/blob/master/src/main/resources/assets/languagereload/lang/en_us.json#L7

@Madis0
Copy link
Member Author

Madis0 commented Nov 4, 2022

Fixed in v4.4.6 thanks to Mod Menu folks

the tl;dr is that
if you want to change some language strings
you don't have to use the mod's namespace (root folder name) the same way you would when you change the textures
just use a custom namespace like fo

@Madis0 Madis0 closed this as completed Nov 4, 2022
@Madis0
Copy link
Member Author

Madis0 commented Mar 20, 2023

image
4.7.0-alpha.4, Russian only

@Madis0 Madis0 reopened this Mar 20, 2023
@Madis0 Madis0 added this to To do in 4.7.0 via automation Mar 20, 2023
@Madis0
Copy link
Member Author

Madis0 commented Apr 2, 2023

Present as of 4.7.0-beta.3, but I dunno how to fix, so I just updated the original issue and will untrack it from the project.

@Madis0 Madis0 removed this from To do in 4.7.0 Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant