Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load mod-defined resources earlier #480

Open
Madis0 opened this issue Jul 30, 2022 · 2 comments
Open

Load mod-defined resources earlier #480

Madis0 opened this issue Jul 30, 2022 · 2 comments
Labels
enhancement A new feature or improvement

Comments

@Madis0
Copy link
Contributor

Madis0 commented Jul 30, 2022

Mod Menu has an API for mods, which, among other things contains translatable descriptions and summaries.

A year ago I discovered that most mods actually don't use the summaries, which gave me a creative idea - what if I made a resource pack for my modpack to make all summaries consistent? So I did, people liked it and contributed translations to it.

However, recently some modders and translators have discovered the feature, and due to the way Mod Menu loads these strings later than the resource packs, the resource pack string becomes useless for those mods.

So here is my suggestion: what if you loaded mod-defined descriptions and summaries earlier than the resource packs? It would then work similarly to how resource packs can change a mod's textures.

Related to #401

@Madis0
Copy link
Contributor Author

Madis0 commented Nov 4, 2022

Prospector and haykam helped me fix this - my resource pack used Mod Menu's namespace but

by using modmenu's namespace, you can only replace things that Mod Menu has jurisdiction over

so using a custom namespace fixed the issue. Language files apparently don't work the same as texture files and can be referenced from any namespace.

@Madis0 Madis0 closed this as completed Nov 4, 2022
@Madis0
Copy link
Contributor Author

Madis0 commented Apr 2, 2023

I'm having this issue again.
My resource pack provides a string for Iris' summary and Iris itself does too, somehow Iris' prevails in some languages.
Why does mine not take precedence if it is applied above "Fabric Mods" in resource packs list?

In Iris:

  "modmenu.summaryTranslation.iris":"Современный графический мод для загрузки существующих наборов шейдеров Optifine.",
  "modmenu.descriptionTranslation.iris": "Современный графический мод для Minecraft, предназначенный для загрузки существующих наборов шейдеров формата Optifine."

in my pack:

    "modmenu.summaryTranslation.iris": "Шейдеры OptiFine'а\n§9✎§8 Отключение мода, выбор шейдеров, ...",

Note: not all languages have those strings in Iris, not even English does.

@Madis0 Madis0 reopened this Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A new feature or improvement
Projects
None yet
Development

No branches or pull requests

2 participants