Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

Should we implement "Sentry"? If so, should we enable it by default? #14

Closed
nsde opened this issue Oct 12, 2022 · 5 comments
Closed

Should we implement "Sentry"? If so, should we enable it by default? #14

nsde opened this issue Oct 12, 2022 · 5 comments
Labels
question Further information is requested

Comments

@nsde
Copy link
Contributor

nsde commented Oct 12, 2022

I think the Vanilla Installer might crash often, as it's in the alpha developement stage right now.

Should we log crash reports to improve our software? Opt-in or opt-out?
Sentry is an open source tool for that: https://github.com/getsentry/sentry
Should we use it? It seems to have a nice dashboard.


My opinion:
We start with opt-out (not hidden in submenus or anything).
The more stable this project gets, the more we can care about privacy.

When the project is in the beta stage, we can set it to opt-in.

@Madis0
Copy link
Member

Madis0 commented Oct 12, 2022

Perhaps a dumb question, but what part of this can actually "crash"? It seems more likely users will just get errors, which can be logged but not all of them should be directly sent somewhere.

@osfanbuff63
Copy link
Member

osfanbuff63 commented Oct 12, 2022

Perhaps a dumb question, but what part of this can actually "crash"? It seems more likely users will just get errors, which can be logged but not all of them should be directly sent somewhere.

There's cases where it might hang, but I couldn't actually find a sys.exit in the main.py, which is interesting. It's probably worth implementing some exits in cases where we know it'll fail, if we run into them.

@Madis0
Copy link
Member

Madis0 commented Oct 12, 2022

Right. Well, currently I am against this idea and would rather suggest making it really easy for users to report this stuff (stack trace + version/system data templates, direct links to GitHub and Discord).
Can be reconsidered later if there still seems to be a need for this.

@Madis0 Madis0 closed this as completed Oct 12, 2022
@nsde
Copy link
Contributor Author

nsde commented Oct 12, 2022

what part of this can actually "crash"?

Oh, I think I have expressed incorrectly. I mean errors in general.

@Madis0 Madis0 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 12, 2022
@nsde
Copy link
Contributor Author

nsde commented Oct 12, 2022

I am against this idea and would rather suggest making it really easy for users to report this stuff

Okay! I'm OK with your choice since I was also unsure. But I agree with your point that we should make error reporting easier. I can do this.

@nsde nsde added the question Further information is requested label Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants