Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

New GUI #31

Merged
merged 4 commits into from
Oct 27, 2022
Merged

New GUI #31

merged 4 commits into from
Oct 27, 2022

Conversation

tuxinal
Copy link
Contributor

@tuxinal tuxinal commented Oct 25, 2022

Implements the new GUI proposed in #28

image

I haven't tested this on Windows and other python versions besides 3.10 yet. please do so if you have the chance
(you might also have to install the Inter font until i figure out how to include it in the application itself)

@tuxinal
Copy link
Contributor Author

tuxinal commented Oct 25, 2022

@nsde i have made some changes to how the get_dir/set_dir functions work in main.py. the current implementation made the packwiz bootstrapper appear inside the home directory on linux systems and it seems unnecessary as far as i can tell. i have discussed this with osfanbuff on discord and they said it should be okay. i wanted to ask if you think there is any reason to keep the current functionality.

@osfanbuff63 osfanbuff63 self-requested a review October 25, 2022 14:12
@nsde
Copy link
Contributor

nsde commented Oct 25, 2022

LGTM, but:

Also, as of right now, the fork don't actually implement the new GUI, but the commits look like preparations for that.

@osfanbuff63
Copy link
Member

Also, as of right now, the fork don't actually implement the new GUI, but the commits look like preparations for that

Tested it briefly locally, and it does seems to implement it. Haven't gone through everything yet, so I'll leave a review once I get through it.

Only thing I noticed is that it doesn't work on 3.11 but that's pyside6's fault, we'll just need to wait there.

@tuxinal
Copy link
Contributor Author

tuxinal commented Oct 25, 2022

the theme names are based on catppuccin's names for the colors. i suppose i can change them to be more descriptive.
what method would you suggest to avoid rate limits?

Copy link
Member

@osfanbuff63 osfanbuff63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned earlier, Qt doesnt have a build out yet for python 3.11 (although likely all that's needed is a dep update) which isn't your fault ofc - so it doesn't work on 3.11 yet.

A couple bugs here and there, but overall it's pretty good (and works)! It might be worth adding a QIcon, and it doesn't scale when you maximize it, but those are relatively trivial.

vanilla-installer/main.py Outdated Show resolved Hide resolved
vanilla-installer/theme.py Show resolved Hide resolved
vanilla-installer/gui.py Show resolved Hide resolved
* change color names
* add credits
* change window title
@osfanbuff63 osfanbuff63 added this to the Full Release milestone Oct 26, 2022
@osfanbuff63 osfanbuff63 linked an issue Oct 26, 2022 that may be closed by this pull request
1 task
Copy link
Member

@osfanbuff63 osfanbuff63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple things, but otherwise looking pretty good. If you (or anyone else) wants to do a PR for a settings menu for an API token or something like that, feel free - but I'd kinda like to get this merged if possible.

vanilla-installer/gui.py Outdated Show resolved Hide resolved
vanilla-installer/gui.py Outdated Show resolved Hide resolved
currently contains options to change the gh api key to be used
also make sure the installation process is only ran once at a time
Co-authored-by: osfanbuff63 <91388253+osfanbuff63@users.noreply.github.com>
Copy link
Member

@osfanbuff63 osfanbuff63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@osfanbuff63 osfanbuff63 merged commit 44d2206 into Fabulously-Optimized:main Oct 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Design proposal
3 participants