-
Notifications
You must be signed in to change notification settings - Fork 6
Conversation
@nsde i have made some changes to how the |
LGTM, but:
Also, as of right now, the fork don't actually implement the new GUI, but the commits look like preparations for that. |
Tested it briefly locally, and it does seems to implement it. Haven't gone through everything yet, so I'll leave a review once I get through it. Only thing I noticed is that it doesn't work on 3.11 but that's pyside6's fault, we'll just need to wait there. |
the theme names are based on catppuccin's names for the colors. i suppose i can change them to be more descriptive. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned earlier, Qt doesnt have a build out yet for python 3.11 (although likely all that's needed is a dep update) which isn't your fault ofc - so it doesn't work on 3.11 yet.
A couple bugs here and there, but overall it's pretty good (and works)! It might be worth adding a QIcon
, and it doesn't scale when you maximize it, but those are relatively trivial.
* change color names * add credits * change window title
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple things, but otherwise looking pretty good. If you (or anyone else) wants to do a PR for a settings menu for an API token or something like that, feel free - but I'd kinda like to get this merged if possible.
currently contains options to change the gh api key to be used also make sure the installation process is only ran once at a time
Co-authored-by: osfanbuff63 <91388253+osfanbuff63@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Implements the new GUI proposed in #28
I haven't tested this on Windows and other python versions besides 3.10 yet. please do so if you have the chance
(you might also have to install the Inter font until i figure out how to include it in the application itself)