Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when calling game.CleanUpMap() within ENT:StartTouch #1142

Closed
Spacetech opened this issue May 26, 2014 · 3 comments
Closed

Crash when calling game.CleanUpMap() within ENT:StartTouch #1142

Spacetech opened this issue May 26, 2014 · 3 comments
Labels
Cannot confirm The issue cannot be confirmed by the developers. Crash The issue is a "random" runtime crash. Invalid/No-info The issue doesn't have enough information to be fixed.

Comments

@Spacetech
Copy link

The dedicated server crashes when you call game.CleanUpMap() within ENT:StartTouch of a map created brush type entity (a trigger).

The client and server build are 14.0.4.19.

@UnderscoreKilburn
Copy link

It's not an easy fix because that's not something you're supposed to do in the first place. You are immediately deleting that brush and replacing it with an identical copy before it even has a chance to fully process the collision event, of course things are going to screw up, just use timer.Simple in that case.

@robotboy655
Copy link
Contributor

The crash kinda makes sense, because if you remove the entity and immediately recreate it, new entity will call ENT:StartTouch again, thus creating an infinite loop.

@robotboy655 robotboy655 added the Invalid/No-info The issue doesn't have enough information to be fixed. label Jul 31, 2017
@Kefta
Copy link
Contributor

Kefta commented Aug 2, 2018

You could check if the engine is in the process of a physics callback when game.CleanUpMap is called, and queue it if so (same as Facepunch/garrysmod-requests#940 / Facepunch/garrysmod-requests#894).

@robotboy655 robotboy655 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 7, 2024
@robotboy655 robotboy655 added the Cannot confirm The issue cannot be confirmed by the developers. label Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cannot confirm The issue cannot be confirmed by the developers. Crash The issue is a "random" runtime crash. Invalid/No-info The issue doesn't have enough information to be fixed.
Projects
None yet
Development

No branches or pull requests

4 participants