Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Entity.Remove queue removal in physics callbacks #940

Closed
Kefta opened this issue Mar 19, 2017 · 5 comments
Closed

Make Entity.Remove queue removal in physics callbacks #940

Kefta opened this issue Mar 19, 2017 · 5 comments

Comments

@Kefta
Copy link

Kefta commented Mar 19, 2017

See here: https://facepunch.com/showthread.php?t=1537303&p=51983032&viewfull=1#post51983032

@Bo98
Copy link

Bo98 commented Mar 19, 2017

This is already covered if we get #894.

@Kefta
Copy link
Author

Kefta commented Mar 19, 2017

Doesn't it rely on the user to change their Remove code?

@Bo98
Copy link

Bo98 commented Mar 19, 2017

Yes, but if you are going to change Entity:Remove's behaviour, then what about all the other functions that people may want to call post simulation?

Entity:Remove can be changed if it's really wanted but a solution for everything else is still needed. I'm assuming you are wanting it this way so old addons don't have to be updated?

@Kefta
Copy link
Author

Kefta commented Mar 19, 2017

I was thinking of a convenience factor, but you are correct about it maintaining old addons. I'm not arguing against a post simulation queue to be added, but this is a very specific case for Remove.

@robotboy655
Copy link
Contributor

Entity.Remove always queued its removals.

@robotboy655 robotboy655 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants