Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed endroundtimer not stopping when forcing roundrestart #1308

Merged
merged 1 commit into from Dec 29, 2016
Merged

Fixed endroundtimer not stopping when forcing roundrestart #1308

merged 1 commit into from Dec 29, 2016

Conversation

HagenKL
Copy link
Contributor

@HagenKL HagenKL commented Dec 24, 2016

I always wondered why the round was restarting twice when forcing roundrestart post round.

markusmarkusz
markusmarkusz approved these changes Dec 24, 2016
View reviewed changes
Copy link
Contributor

@markusmarkusz markusmarkusz left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I never thought the problem might come from this.

@robotboy655 robotboy655 added the TTT The pull request is for TTT and will be handled by svdm. label Dec 24, 2016
@svdm
Copy link
Collaborator

svdm commented Dec 29, 2016

Nice, though would've been prevented if timer.Stop printed a (dev) message when you try to stop a timer that does not exist.

@svdm svdm merged commit 77534d7 into Facepunch:master Dec 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusmarkusz markusmarkusz markusmarkusz approved these changes

@mcNuggets1 mcNuggets1 mcNuggets1 approved these changes

Assignees
No one assigned
Labels
TTT The pull request is for TTT and will be handled by svdm.
Projects
None yet
Milestone
No milestone
5 participants
@HagenKL @svdm @markusmarkusz @mcNuggets1 @robotboy655