TTT: Allow popups to be toggled with their hotkey #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can be changed in the settings menu.
|
Also, apologies if the CVar is not located in the ideal place. It made sense to me to place it there, but you can move it as you see right. |
Kefta
reviewed
Sep 18, 2017
sanny-io
suggested changes
Sep 18, 2017
| @@ -524,6 +524,12 @@ function CLSCORE:Reopen() | |||
| end | |||
| end | |||
|
|
|||
| function CLSCORE:Toggle() | |||
| if self.Panel and self.Panel:IsValid() then | |||
There was a problem hiding this comment.
You should remove both if statements and use IsValid(self.Panel) instead.
| @@ -524,6 +524,12 @@ function CLSCORE:Reopen() | |||
| end | |||
| end | |||
|
|
|||
| function CLSCORE:Toggle() | |||
| if self.Panel and self.Panel:IsValid() then | |||
| self.Panel:SetVisible(not self.Panel:IsVisible()) | |||
There was a problem hiding this comment.
There's a function to do this. self.Panel:ToggleVisible()
robotboy655
added
the
TTT
added 2 commits
September 19, 2017 11:24
* Replaced "self.Panel and self.Panel:IsValid()" with "IsValid(self.Panel)". * Cached the convar in cl_equip
|
To be honest I'd just remove the convar entirely, why disable it if there's no downside? |
|
Honestly? I don't think it's needed either, but I was adding that in case anyone would prefer it as it is for some crazy reason. People don't always like these changes. 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QoL change
Allows popups like the Traitor shop or the round end pop to be closed with their hotkey (Default: C) instead of using the mouse.
It's a small thing but it's a huge relief, really.
Can be changed in the settings menu, if somebody doesn't like (but why the hell not lol)