Fix error when gamemode has no valid settings #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes error: [MENU ERROR] lua/menu/mainmenu.lua:185: bad argument #1 to 'pairs' (table expected, got string)
dennisstewart
added a commit
to dennisstewart/nickcagematch-ttt
that referenced
this pull request
Apr 17, 2020
* Model keyvalue works on more NPCs * Change prop_effects FX on hover * 64bit SRCDS UI theme fixes * DListView_ColumnPlain fix for extra panels Fixes Facepunch/garrysmod-issues#4365 * Fix Faceposer forcing hidden flexes to 0 This caused problems with DME eyelids * Utilized: Vector and angle `Unpack` metamethods in`util.TypeToString` (Facepunch#1622) * Utilized: Vevtor and angle `Unpack` metamethods in`util.TypeToString` * Updated: `TypeToString` * Removed: Whitespace * Switched icon editor to sliders for skins/bg * Delete closecaption files They are pointless here * volume to loading screen Co-Authored-By: Nurdism <nurdism.io@gmail.com> * DisableClipping restores to oldstate Facepunch/garrysmod-issues#4375 * TTT: Update Portuguese translation (Facepunch#1635) * TTT: Portuguese translation fixes (Facepunch#1636) * Link to Garry's Mod wiki pages have changed. (Facepunch#1637) * Offline workshop changes Necessary to display addons names and not error * config_default.cfg reworked (Facepunch#1632) - Removed `spawnmenu_icon_precache` because it is not a valid command; - Modified the `mp_decals` to the value of `2048` to equal the value of `r_decals` (`r_decals` gets resetted everytime you launch the game, so setting `r_decals` to `5000` will get its value back to `2048` when you relaunch the game, while `mp_decals` still with the value of `5000` because `mp_decals` it is stored in the `config.cfg` file, while `r_decals` is not, and to make both equal, here is the solution); - Modified the value of the `sensitivity` command to the value of `6` instead of `8`. * Optimized player.GetBy* functions in player.lua (Facepunch#1628) * Update player.lua * Update player.lua * Update player.lua Style changes. * Fix SendUserMessage error when calling clientside (Facepunch#1626) * Fix SendUserMessage error when calling clientside Though all this is deprecated, the function still shouldn't error when called from the client. I also removed the ``SERVER`` check inside ``usermessage.Hook`` since it never passed due to ``SERVER`` not being localised before the module call. * Update usermessage.lua * Update usermessage.lua Formatting changes to match the rest of the files * Updated language files * Fixed Snarks not attacking sometimes * Read only drag'n'drop stuff You can only copy from readonly drag'n'drop panels. Used for Weapons/NPCs/Entities tabs in the spawnmenu to prevent ability to delete icons and have to resort to restarting the map to get them back * Update .gitignore * Spawnmenu resizing saves And changes to make it usable on stupidly low resolutions * drag'n'drop selection changes * map categories changes * spawnlist revert feature * DefaultUnderline font changes Also increased width of dropdown in mutliplayer tab to fit the "no workshop downloads" option * Updated language files GameUI has the multiplayer tab additions * TTT: more fixes for Portuguese translation (Facepunch#1640) * Fixed NPCs floating * Sandbox hints don't show with Camera wep * Fixed errors with drag'n'drop Fixes new spawnlist headers erroring * Fixed "Make Persistent" option appearing when its disabled Fixed "Make Persistent" option appearing when Persistence is disabled * Made sbox_godmode work in singleplayer * Clearly tell player which options are MP only * Tools can be used on non vphysics brushes You can place buttons on gm_construct mirror and white room, etc. * spawnmenu right click menu fixes Fixed unselected icon right click menus changing when anything has been selected in the spawnmenu Translated right click menu for spawnlist headers * Fixed iconless notifications making errors OOPSIE * weapon_base doesn't error in NPC hands * Fix default skin to use self instead of SKIN (Facepunch#1641) * Fix error when gamemode has no valid settings (Facepunch#1643) Fixes error: [MENU ERROR] lua/menu/mainmenu.lua:185: bad argument #1 to 'pairs' (table expected, got string) * Main menu fixes/changes Main menu no longer errors if we failed to load API manifest or its fields changed Blacklisted servers display why they were blacklisted in console * TTT: Remove unnecessary GetWeapons and HasWeapon overrides (Facepunch#1648) * TTT: Fix GetEyeTrace override (Facepunch#1647) - Only do caching clientside so that it allows lag compensation to retrace - Use FrameNumber instead of CurTime so that it doesn't clash with prediction - Default to MASK_SOLID as the trace does internally, so that traces that explicitly specify MASK_SOLID can use the cached results of traces with no explicit mask * Fix GetEyeTraceNoCursor caching (Facepunch#1645) * Fix GetEyeTraceNoCursor caching Fixes Facepunch/garrysmod-issues#4430. Also - Use FrameNumber instead of CurTime for caching so that it doesn't clash with prediction - Added skipcache arg to both GetEyeTrace and GetEyeTraceNoCursor for skipping the clientside cache - Check if the PlayerTrace/PlayerAimTrace vars are tables before returning them in-case they're modified by other addons accidentally * Fix styling * Remove skipcache arg * gmod_language for loading screen * Replace Delete with #spawnmenu.menu.delete (Facepunch#1646) * TTT: fix "select language" translation inconsistencies (Facepunch#1649) * Spawnmenu UI improvements Translated right click menus for Tools in spawnlists & multiselection right click menu (Community) Tool search in spawnlists now works with localization Spawnicons and spawnlist tools now obey read only parents (such as spawnlist Search) Post Processing icons can now be deleted from spawnlists * FOF spawnpoint ents * FOF maps category * Read only ContentHeader no longer editable * Use correct rendermode/groups and use actual enums * TTT: fixes to Chinese and Portuguese (Facepunch#1650) * TTT: add Italian translation (Facepunch#1652) * TTT: additional language fixes (Facepunch#1653) Co-authored-by: Perkzitos <30274161+Perkzitos@users.noreply.github.com> Co-authored-by: svdm <svdm@users.noreply.github.com> * notification.AddProgress upgrades notification.AddProgress now has an optional 3rd argument - fraction - 0 to 1 value overriding the progress bar animation to show a desired value Adjusted visuals for notification.AddProgress & made them truly infinite * Added a 3rd argument to search.GetResults (optional) * Create OptionsSubVoice.res * sbox_search_maxresults & other search improvements Added sbox_search_maxresults Spawnmenu search prop indexer now uses notification.AddProgress over the old blue progress bar ".mdl" part of models paths is no longer being searched Having your spawnmenu closed during search will automatically update search results next time you open it * Ammo lib update (Facepunch#1487) * Bad tbl.name no longer silently fails * Made ammo names case-insensitive. * Add effects.GetList (Facepunch#1527) Solves Facepunch/garrysmod-requests#1209. Pretty much a copy of [weapons.GetList](https://github.com/Facepunch/garrysmod/blob/394ae745df8f8f353ea33c8780f012fc000f4f56/garrysmod/lua/includes/modules/weapons.lua#L169-L177). * Constraint lib minor fixes & improvements Updates "constraints" var on the constraint system when it matters Fixed constraint.Pulley comparing one of its arguments to a global Fixed constraint.Hydraulic's 4th retval always being nil Removed reduntant usage of GetTable() Rid of some unused locals * Added SetTooltipPanelOverride * Toolmenu filters expand categories * Update constraint.lua Co-authored-by: Rubat <robotboy655@gmail.com> Co-authored-by: Deyan Dobromirov <dvd_video@abv.bg> Co-authored-by: Nurdism <nurdism.io@gmail.com> Co-authored-by: Perkzitos <30274161+Perkzitos@users.noreply.github.com> Co-authored-by: iViscosity <iViscositygaming@gmail.com> Co-authored-by: Rubat <robotboy655@facepunchstudios.com> Co-authored-by: Spar <developspartv@gmail.com> Co-authored-by: Gabriel Francisco <gabrinelson27@gmail.com> Co-authored-by: Collin (code_gs) <collings509@gmail.com> Co-authored-by: DBotThePony <dbotthepony@yandex.ru> Co-authored-by: LetsTwist <31796707+LetsTwist@users.noreply.github.com> Co-authored-by: Alessandro Levante <62677560+PinoMartirio@users.noreply.github.com> Co-authored-by: svdm <svdm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some gamemodes simply do not have a configuration and leave a blank string, and when you have it set and try to enter in any server, the following error is thrown:
An example gamemode is The Hidden.