Use ents/player.Iterator instead of GetAll

garrysmod/gamemodes/base/gamemode/cl_init.lua

@@ -196,7 +196,7 @@ function GM:OnChatTab( str )
 
 	if ( LastWord == nil ) then return str end
 
-	for k, v in ipairs( player.GetAll() ) do
+	for _, v in player.Iterator() do
 
 		local nickname = v:Nick()
 

garrysmod/gamemodes/base/gamemode/cl_scoreboard.lua

@@ -127,10 +127,10 @@ local PLAYER_LINE = {
 
 			self.Mute.PaintOver = function( s, w, h )
 				if ( !IsValid( self.Player ) ) then return end
-			
+
 				local a = 255 - math.Clamp( CurTime() - ( s.LastTick or 0 ), 0, 3 ) * 255
 				if ( a <= 0 ) then return end
-				
+
 				draw.RoundedBox( 4, 0, 0, w, h, Color( 0, 0, 0, a * 0.75 ) )
 				draw.SimpleText( math.ceil( self.Player:GetVoiceVolumeScale() * 100 ) .. "%", "DermaDefaultBold", w / 2, h / 2, Color( 255, 255, 255, a ), TEXT_ALIGN_CENTER, TEXT_ALIGN_CENTER )
 			end
@@ -240,8 +240,8 @@ local SCORE_BOARD = {
 		--
 		-- Loop through each player, and if one doesn't have a score entry - create it.
 		--
-		
-		for id, pl in ipairs( player.GetAll() ) do
+
+		for _, pl in player.Iterator() do
 
 			if ( IsValid( pl.ScoreEntry ) ) then continue end
 

garrysmod/gamemodes/sandbox/gamemode/persistence.lua

@@ -19,12 +19,12 @@ hook.Add( "PersistenceSave", "PersistenceSave", function( name )
 	local PersistPage = ( name or GetConVarString( "sbox_persist" ) ):Trim()
 	if ( PersistPage == "" ) then return end
 
-	local Ents = ents.GetAll()
+	local Ents = {}
 
-	for k, v in ipairs( Ents ) do
+	for _, v in ents.Iterator() do
 
-		if ( !v:GetPersistent() ) then
-			Ents[ k ] = nil
+		if ( v:GetPersistent() ) then
+			table.insert( Ents, v )
 		end
 
 	end

garrysmod/lua/autorun/properties/drive.lua

@@ -17,7 +17,7 @@ properties.Add( "drive", {
 		if ( ent:GetClass() == "prop_vehicle_jeep" || ent:GetClass() == "prop_vehicle_jeep_old" ) then return false end
 
 		-- Make sure nobody else is driving this or we can get into really invalid states
-		for id, pl in ipairs( player.GetAll() ) do
+		for _, pl in player.Iterator() do
 			if ( pl:GetDrivingEntity() == ent ) then return false end
 		end
 

garrysmod/lua/includes/extensions/player.lua

@@ -263,21 +263,19 @@ end
 
 -- These are totally in the wrong place.
 function player.GetByAccountID( ID )
-	local players = player.GetAll()
-	for i = 1, #players do
-		if ( players[i]:AccountID() == ID ) then
-			return players[i]
+	for _, pl in player.Iterator() do
+		if ( pl:AccountID() == ID ) then
+			return pl
 		end
 	end
 
 	return false
 end
 
 function player.GetByUniqueID( ID )
-	local players = player.GetAll()
-	for i = 1, #players do
-		if ( players[i]:UniqueID() == ID ) then
-			return players[i]
+	for _, pl in player.Iterator() do
+		if ( pl:UniqueID() == ID ) then
+			return pl
 		end
 	end
 
@@ -286,10 +284,10 @@ end
 
 function player.GetBySteamID( ID )
 	ID = string.upper( ID )
-	local players = player.GetAll()
-	for i = 1, #players do
-		if ( players[i]:SteamID() == ID ) then
-			return players[i]
+
+	for _, pl in player.Iterator() do
+		if ( pl:SteamID() == ID ) then
+			return pl
 		end
 	end
 
@@ -298,10 +296,10 @@ end
 
 function player.GetBySteamID64( ID )
 	ID = tostring( ID )
-	local players = player.GetAll()
-	for i = 1, #players do
-		if ( players[i]:SteamID64() == ID ) then
-			return players[i]
+
+	for _, pl in player.Iterator() do
+		if ( pl:SteamID64() == ID ) then
+			return pl
 		end
 	end
 

garrysmod/lua/includes/gmsave.lua

@@ -86,12 +86,12 @@ end
 
 function gmsave.SaveMap( ply )
 
-	local Ents = ents.GetAll()
+	local Ents = {}
 
-	for k, v in ipairs( Ents ) do
+	for _, v in ents.Iterator() do
 
-		if ( !gmsave.ShouldSaveEntity( v, v:GetSaveTable() ) || v:IsConstraint() ) then
-			Ents[ k ] = nil
+		if ( gmsave.ShouldSaveEntity( v, v:GetSaveTable() ) && !v:IsConstraint() ) then
+			table.insert( Ents, v )
 		end
 
 	end

garrysmod/lua/includes/modules/duplicator.lua

@@ -996,7 +996,7 @@ end
 --
 function RemoveMapCreatedEntities()
 
-	for k, v in ipairs( ents.GetAll() ) do
+	for _, v in ents.Iterator() do
 
 		if ( v:CreatedByMap() and ShouldMapEntityBeRemoved( v, v:GetClass() ) ) then
 			v:Remove()

garrysmod/lua/includes/modules/scripted_ents.lua

@@ -105,7 +105,7 @@ function Register( t, name )
 		end
 
 		-- Update entity table of entities that are based on this entity
-		for _, e in ipairs( ents.GetAll() ) do
+		for _, e in ents.Iterator() do
 			if ( IsBasedOn( e:GetClass(), name ) ) then
 
 				table.Merge( e, Get( e:GetClass() ) )

garrysmod/lua/includes/modules/team.lua

@@ -105,7 +105,7 @@ end
 function TotalDeaths(index)
 
 	local score = 0
-	for id,pl in ipairs( player.GetAll() ) do
+	for _, pl in player.Iterator() do
 		if (pl:Team() == index) then
 			score = score + pl:Deaths()
 		end
@@ -117,7 +117,7 @@ end
 function TotalFrags(index)
 
 	local score = 0
-	for id,pl in ipairs( player.GetAll() ) do
+	for _, pl in player.Iterator() do
 		if (pl:Team() == index) then
 			score = score + pl:Frags()
 		end
@@ -136,7 +136,7 @@ function GetPlayers(index)
 
 	local TeamPlayers = {}
 
-	for id,pl in ipairs( player.GetAll() ) do
+	for _, pl in player.Iterator() do
 		if (IsValid(pl) and pl:Team() == index) then
 			table.insert(TeamPlayers, pl)
 		end

garrysmod/lua/includes/modules/weapons.lua

@@ -77,7 +77,7 @@ function Register( t, name )
 	if ( old != nil ) then
 
 		-- Update SWEP table of entities that are based on this SWEP
-		for _, e in ipairs( ents.GetAll() ) do
+		for _, e in ents.Iterator() do
 			local class = e:GetClass()
 
 			if ( class == name ) then