Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support nullable fields #39

Closed
ejball opened this issue Nov 2, 2022 · 1 comment · Fixed by #40
Closed

Support nullable fields #39

ejball opened this issue Nov 2, 2022 · 1 comment · Fixed by #40

Comments

@ejball
Copy link
Contributor

ejball commented Nov 2, 2022 •
edited
Loading

Facility doesn't currently distinguish missing fields from null fields when reading DTOs from JSON, and never writes null when writing DTOs to JSON. A nullable field would require clients and servers to support null fields and distinguish them from missing fields. They could be restricted to "normal" fields.
@ejball
Copy link
Contributor Author

ejball commented Nov 2, 2022 •
edited
Loading

Possible syntax:

  • [nullable] title: string;
  • title: nullable<string>;
  • title: string?

This was referenced Nov 2, 2022
Closed
Closed
ejball added a commit to ejball/Facility that referenced this issue Nov 3, 2022
@ejball
Support nullable fields.
0fd6e30 
Fixes FacilityApi#39.
@ejball ejball mentioned this issue Nov 3, 2022
Merged
@ejball ejball closed this as completed in #40 Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support nullable fields. ejball/Facility
1 participant
@ejball