Remove wallet to clear up dependencies + add go.mod #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulBernier
approved these changes
Aug 20, 2020
|
Great clean up! Can you create an issue for tracking in the factom-walletd repo? |
Closed
PaulBernier
pushed a commit
that referenced
this pull request
Dec 19, 2020
PaulBernier
pushed a commit
that referenced
this pull request
Dec 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The /wallet/ subfolder doesn't really belong into this repo. It's not used by the factom lib and it's not used by factomd. The projects using it are factom-walletd and the enterprise wallet. I move to make the wallet either its own repo, or a sub-repo of one of the two aforementioned projects (probably factom-walletd).
The wallet folder was the cause of all go.mod dependency issues and without it, the go.mod file is relatively small and simple. Before there were hard to fix recursive dependency problems that are now gone.