add send_via_river special game #446
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsquaredxc
reviewed
Mar 31, 2024
clifffrey
requested changes
Apr 7, 2024
| " flasks of ", | ||
| formatted_food, | ||
| " to team ", | ||
| team_strings[enemy], |
There was a problem hiding this comment.
it would be more consistent to use the same messages, give or take, as feeding.lua does, i.e.
" to ", Functions.team_name_with_color(enemy), "'s biters!"
| if inventory then | ||
| for item_name, item_count in pairs(inventory.get_contents()) do | ||
| if science_packs[item_name] ~= nil then | ||
| inventory.remove({ name = item_name, count = item_count }) |
There was a problem hiding this comment.
can't you just directly use Feeding.lua:Public.feed_biters ? and delete a lot of this code?
| end | ||
| end | ||
|
|
||
| local function drbuttons_temporary_tick_handler(event) |
There was a problem hiding this comment.
perhaps rename to "send_via_river_" instead of "drbuttons_" ?
| global.send_via_river_special_init = false | ||
| global.send_via_river_specialbox_check_interval = 60*60*5 | ||
|
|
||
| local disabled_food = { |
There was a problem hiding this comment.
again, it would be great to use Tables for this if you can
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of the changes:
Send your science via the inserters at the river!
inserters are spaced every ~400 units. More inserters you use, the faster you can send science.
Tested Changes: