Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check support for Python 3.6 #358

Closed
rbarrois opened this issue Apr 7, 2017 · 6 comments
Closed

Check support for Python 3.6 #358

rbarrois opened this issue Apr 7, 2017 · 6 comments

Comments

@rbarrois
Copy link
Member

rbarrois commented Apr 7, 2017

With Python 3.6 out, we should make sure that it is properly supported by factory_boy.

This should work out of the box; but some steps are required to check it:

  1. Add Python 3.6 to https://github.com/FactoryBoy/factory_boy/blob/master/tox.ini
  2. Add that build in https://github.com/FactoryBoy/factory_boy/blob/master/.travis.yml
  3. Make a pull request, wait for the travis build, and check that it's still working.
  4. Update README.rst and classifiers at https://github.com/FactoryBoy/factory_boy/blob/master/setup.py#L57 to state that Python 3.6 is supported.
mbaechtold added a commit to mbaechtold/factory_boy that referenced this issue Apr 7, 2017
mbaechtold added a commit to mbaechtold/factory_boy that referenced this issue Apr 7, 2017
@mbaechtold
Copy link
Contributor

May I suggest to split the "bonus idea" into separate issues?

@rbarrois
Copy link
Member Author

rbarrois commented Apr 7, 2017

@mbaechtold good point; done.

mbaechtold added a commit to mbaechtold/factory_boy that referenced this issue Apr 7, 2017
In fact, this makes all the tests be run under Python 3.6. If the tests succeed, we assume there is support for Python 3.6

Closes FactoryBoy#358
rbarrois pushed a commit that referenced this issue Apr 7, 2017
In fact, this makes all the tests be run under Python 3.6. If the tests succeed, we assume there is support for Python 3.6

Closes #358
@jeffwidman jeffwidman reopened this Apr 7, 2017
@jeffwidman
Copy link
Member

@mbaechtold do you mind also adding the python 3.6 to the shields.io badge? (just modify the readme)

Thanks!

@mbaechtold
Copy link
Contributor

mbaechtold commented Apr 8, 2017 via email

@rbarrois
Copy link
Member Author

rbarrois commented Apr 8, 2017

@jeffwidman I'm wondering if the shields.io wouldn't be based on the PyPI metadata; in which case they would update automatically once we release a version, but not before 😕

@jeffwidman
Copy link
Member

@rbarrois is totally right; I just forgot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants