Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make linkcheck fails in CI #771

Closed
rbarrois opened this issue Aug 13, 2020 · 4 comments · Fixed by #837
Closed

make linkcheck fails in CI #771

rbarrois opened this issue Aug 13, 2020 · 4 comments · Fixed by #837
Assignees
@francoisfreitag
Labels
Bug Packaging

Comments

@rbarrois
Copy link
Member

Description

Due to its default implementation, the linkcheck step of make lint triggers rate-limit protections on Github

To Reproduce

Run make linkcheck
@rbarrois
Copy link
Member Author

@francoisfreitag Since you enabled make linkcheck in the first place, do you have some insight on this?

@francoisfreitag francoisfreitag self-assigned this Aug 13, 2020
@francoisfreitag
Copy link
Member

francoisfreitag commented Aug 13, 2020 •
edited

Thanks for the ping, I’ll look into moving the check to a cron job, to avoid running it often and hopefully avoid many requests and the rate limiting.

@francoisfreitag
Copy link
Member

Reporting back on this. Even limiting the number of workers with Sphinx is insufficient to circumvent the 429 Too Many Requests.

Related Sphinx issue sphinx-doc/sphinx#7388.

@jdufresne jdufresne mentioned this issue Nov 1, 2020
Merged
@francoisfreitag francoisfreitag mentioned this issue Nov 8, 2020
Closed
jdufresne added a commit that referenced this issue Dec 9, 2020
@jdufresne
Migrate CI from Travis to GitHub actions
d8b241c 
GitHub actions produces faster results than Travis, resulting in faster
feedback for contributors.

The linkcheck environment was not ported to GitHub actions. This
environment consistently fails with the error:

    429 Client Error: too many requests for url: https://github.com/…

This sometimes happens in Travis, but is more frequent now with the
increase in performance. See issue #771.

The "basepython" tox configuration option was dropped as GitHub actions
default to using the latest Python version which is now 3.9. This avoid
additional configuration in both actions and tox when a new Python is
released.

Fixes #707
@francoisfreitag
Copy link
Member

This issue will be fixed on the next release of Sphinx (version 3.4). Can re-enable linkcheck then, possibly as a cron job instead of running for each PR.

francoisfreitag added a commit to francoisfreitag/factory_boy that referenced this issue Dec 22, 2020
@francoisfreitag
Restore linkcheck builds
e80e8a6 
Builds are scheduled once a week.

Fixes FactoryBoy#771
francoisfreitag added a commit to francoisfreitag/factory_boy that referenced this issue Jan 26, 2021
@francoisfreitag
Restore linkcheck builds
1c05bb1 
Builds are scheduled once a week.

Fixes FactoryBoy#771
@francoisfreitag francoisfreitag mentioned this issue Jan 26, 2021
Merged
francoisfreitag added a commit to francoisfreitag/factory_boy that referenced this issue Feb 11, 2021
@francoisfreitag
Restore linkcheck builds
f26c9c2 
Builds are scheduled once a week.

Fixes FactoryBoy#771
francoisfreitag added a commit to francoisfreitag/factory_boy that referenced this issue Feb 11, 2021
@francoisfreitag
Restore linkcheck builds
3fe131d 
Builds are scheduled once a week.

Fixes FactoryBoy#771
francoisfreitag added a commit to francoisfreitag/factory_boy that referenced this issue Feb 11, 2021
@francoisfreitag
Restore linkcheck builds
917364c 
Builds are scheduled once a week.

Fixes FactoryBoy#771
francoisfreitag added a commit to francoisfreitag/factory_boy that referenced this issue Feb 12, 2021
@francoisfreitag
Restore linkcheck builds
e79a185 
Builds are scheduled once a week.

Fixes FactoryBoy#771
francoisfreitag added a commit to francoisfreitag/factory_boy that referenced this issue Feb 12, 2021
@francoisfreitag
Restore linkcheck builds
82e743c 
Builds are scheduled once a week.

Fixes FactoryBoy#771

Reviewed-by: Raphaël Barrois
francoisfreitag added a commit that referenced this issue Feb 13, 2021
@francoisfreitag
Restore linkcheck builds
b59ef2f 
Builds are scheduled once a week.

Fixes #771

Reviewed-by: Raphaël Barrois
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@francoisfreitag francoisfreitag

Labels
Bug Packaging
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore linkcheck builds francoisfreitag/factory_boy
2 participants
@rbarrois @francoisfreitag