Don't require setting sqlalchemy_session to None when using a factory. #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoisfreitag
approved these changes
Jul 25, 2023
|
Sounds reasonable, thanks for submitting a patch! |
francoisfreitag
added a commit
to francoisfreitag/factory_boy
that referenced
this pull request
Jul 31, 2023
Missed in FactoryBoy#1032.
|
Any chance of a fix version release with this one in it? |
|
@francoisfreitag are there any plans to release 3.3.1 with the fix? I would appreciate it. The bug is still on the latest version but has been fixed for a while. |
|
cc @rbarrois (who cuts the releases) |
|
is there someone else that would be allowed to create the release? |
|
No. |
|
Indeed, that's be pretty nice to get this one released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1031
This fix makes it so that
sqlalchemy_session_factorycan be used without explicitly settingsqlalchemy_session=Nonein a metaclass.