Call evaluate_pre() instead of evaluate() on Maybe decider #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoisfreitag
force-pushed
the
issue-965
branch
from
ef7dea3
to
eec545d
Compare
|
Follow-up to #1010 |
rbarrois
approved these changes
Apr 25, 2024
e19142c introduced evaluate_pre to perform context unrolling before to call the semi-public evaluate(). The Maybe decider was not updated at that time, but its context need to be unrolled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e19142c introduced
evaluate_pre()to perform context unrolling before to call the semi-publicevaluate().The Maybe decider was not updated at that time, but its context need to be unrolled.
Closes #965