Add missing import / requirement #988
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are needed for the imports / requirements.
kingbuzzman
reviewed
Oct 28, 2022
| @@ -1,6 +1,7 @@ | |||
| from django.contrib.auth.models import Group, User | |||
| from django.contrib.contenttypes.models import ContentType | |||
|
|
|||
| import factory | |||
There was a problem hiding this comment.
Several lines in this file use factory.X but the factory import itself was missing... eg:
There was a problem hiding this comment.
Oh I see, yes good catch!
There was a problem hiding this comment.
I don’t think that’s necessary.
https://docs.python.org/3/reference/simple_stmts.html#the-import-statement
import foo.bar.baz # foo, foo.bar, and foo.bar.baz imported, foo bound locallyAnd indeed:
$ python
Python 3.10.8 (main, Oct 13 2022, 21:13:48) [GCC 12.2.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import factory.django
>>> factory.LazyAttribute
<class 'factory.declarations.LazyAttribute'>
There was a problem hiding this comment.
Oh interesting, I either never realized that or long ago forgot that!
kingbuzzman
approved these changes
Oct 31, 2022
| @@ -1 +1,2 @@ | |||
| Django | |||
| factory_boy | |||
There was a problem hiding this comment.
Similarly, the Flask examples need updating.
|
Closing as unnecessary per #988 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are needed for the imports / requirements.