Update and fix tests #41
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sn0opy
force-pushed
the
fix/update_and_fix_tests
branch
from
169bedb
to
e39a3bf
Compare
|
I'll make a different version based on this PR as the DB updated their HAFAS tonight and with that changed the journey id format from seperated by the legacy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several tests failed due to the date/time in the
journey()request being out of the timetable period. I fixed that by actually using the current date. I assume this could still fail on public holidays or weekends with a different timetables.Some others failed because I was running tests on a Windows machine which is using a different encoding when opening files which broke German umlauts. Passing the correct encoding to
open()fixes that.The
nasa/requests/journeys_test.pystill fails with the following error:location missing or invalid. After double checking the station IDs they seem to be valid and one can still request journeys at https://reiseauskunft.insa.de/ and https://www.insa.de/fahrplanauskunft. No idea why.