-
Notifications
You must be signed in to change notification settings - Fork 5
Development FAQ
Artem Kalmykov edited this page Aug 27, 2020
·
2 revisions
- Create a branch from
develop
with a prefix of eitherfeature/
orfix/
. - Push all the changes there.
- Start creating a PR by selecting
develop
as a base branch. - Assign code reviewers (@Artem-Kalmykov).
- Put labels.
- Mark all the checkboxes with
[x]
(but first verify you've done it). - Create a PR.
Each screen should correspond to a clean swift's scene. A new one should be created from Xcode's custom file templates, which can be found here. All the UI should be defined in scene's .xib
file.
Third party dependencies should be connected only with the help of Swift Package Manager. If a dependency is not available through SPM, either find an alternative or connect it manually.
Adding another transmitter is not pipelined and a lot of details should be accounted:
- Add your device to
CGMDeviceType
enum. - Make it available as an option in
SettingsTransmitter
scene andInitialSetupTransmitterTypeViewController
. - Implement a new bluetooth service, which adopts
CGMBluetoothService
protocol. - Make sure that the new bluetooth service is properly injected when needed.