refactor(shm): Send code that works on de-reffed shmem::Message i…

…nto own fn `SendShm`
FairRootGroup · Aug 22, 2022 · a69e9a4 · a69e9a4
1 parent 414e13a
commit a69e9a4
Showing 1 changed file with 15 additions and 13 deletions.
diff --git a/fairmq/shmem/Socket.h b/fairmq/shmem/Socket.h
@@ -261,6 +261,20 @@ class Socket final : public fair::mq::Socket
         return static_cast<int>(TransferCode::error);
     }
 
+    auto SendShm(shmem::Message& msg, int timeout) -> int64_t {
+        auto metaMsg = MakeMetaMsg(msg);
+
+        auto const flags = (timeout == 0) ? ZMQ_DONTWAIT : 0;
+
+        return static_cast<int64_t>(SendMeta(metaMsg, flags, timeout, [this, &msg](std::size_t) {
+            msg.fQueued = true;
+            ++fMessagesTx;
+            auto const size = msg.GetSize();
+            fBytesTx += size;
+            return static_cast<int64_t>(size);
+        }));
+    }
+
   public:
     int64_t Send(mq::MessagePtr& msg, int timeout = -1) override
     {
@@ -270,19 +284,7 @@ class Socket final : public fair::mq::Socket
         }
         assertm(dynamic_cast<shmem::Message*>(msgPtr), "given mq::Message is a shmem::Message");   // NOLINT
         // NOLINTNEXTLINE(cppcoreguidelines-pro-type-static-cast-downcast)
-        auto shmMsg = static_cast<shmem::Message*>(msgPtr);
-
-        auto metaMsg = MakeMetaMsg(*shmMsg);
-
-        auto const flags = (timeout == 0) ? ZMQ_DONTWAIT : 0;
-
-        return static_cast<int64_t>(SendMeta(metaMsg, flags, timeout, [this, &shmMsg](std::size_t) {
-            shmMsg->fQueued = true;
-            ++fMessagesTx;
-            auto const size = shmMsg->GetSize();
-            fBytesTx += size;
-            return static_cast<int64_t>(size);
-        }));
+        return SendShm(*static_cast<shmem::Message*>(msgPtr), timeout);
     }
 
     int64_t Receive(MessagePtr& msg, int timeout = -1) override