Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sorting StateChange callbacks #481

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

ktf
Copy link
Contributor

@ktf ktf commented Sep 5, 2023

No description provided.

If the key of the callback is a number, it will be used to invoke
callbacks with the correct ordering.
@ktf
Copy link
Contributor Author

ktf commented Sep 5, 2023

Is the thread sanitizer known to be broken?

@dennisklein
Copy link
Member

Is the thread sanitizer known to be broken?

yes, it was never green.

@dennisklein dennisklein changed the base branch from master to dev September 5, 2023 13:31
@ktf
Copy link
Contributor Author

ktf commented Sep 5, 2023

Can we have a release with this in? In principle it only affects the case in which you name your callback using a numeric prefix.

@rbx rbx merged commit 3c1723f into FairRootGroup:dev Sep 6, 2023
10 of 11 checks passed
@ktf ktf deleted the allow-sorting-callbacks branch September 6, 2023 07:57
@rbx
Copy link
Member

rbx commented Sep 6, 2023

It is now available with v1.8.0. It also contains your previous contribution.

@ktf
Copy link
Contributor Author

ktf commented Sep 6, 2023

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants