Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Multiple Leaks around FairGeoLoader #1444

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

ChristianTackeGSI
Copy link
Member

Also some small other stylistic changes


Checklist:

Copy link

coderabbitai bot commented Feb 20, 2024

Walkthrough

Walkthrough

The recent updates focus on modernizing memory management across the FairRoot project by introducing smart pointers, specifically std::unique_ptr, to manage dynamic memory automatically. This shift enhances code safety and readability. Additionally, the updates include refactoring variable names for clarity, simplifying constructors, and improving documentation. These changes are spread across the FairRunSim and FairGeoLoader classes, along with modifications in the FairGeoRootBuilder class to support these improvements.

Changes

Files Change Summary
fairroot/base/steer/FairRunSim.cxx, fairroot/base/steer/FairRunSim.h
fairroot/geobase/FairGeoLoader.cxx, fairroot/geobase/FairGeoLoader.h
Updated initialization process in FairRunSim with smart pointers for FairGeoLoader, adjusted variable names, added conditional check for fGeoLoader. Added FairGeoLoader declaration and std::unique_ptr member in FairRunSim. Removed manual initialization in FairGeoLoader constructor, switched to direct member variable usage and std::unique_ptr for fGeoBuilder, updated method returns, and enhanced documentation. Included new #include for FairGeoInterface.h.
fairroot/geobase/FairGeoRootBuilder.cxx, fairroot/geobase/FairGeoRootBuilder.h Simplified constructors, added a new constructor for std::unique_ptr<TGeoManager>, deprecated setGeoManager method in favor of reset, and switched to std::unique_ptr for geoManager.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@karabowi karabowi self-requested a review March 26, 2024 10:16
karabowi
karabowi previously approved these changes Mar 26, 2024
@ChristianTackeGSI
Copy link
Member Author

Do we want to backport this to 19.0? If no, I would postpone merging this until the release is done.

Also some small other stylistic changes
@dennisklein dennisklein merged commit ede7137 into FairRootGroup:dev Apr 1, 2024
17 checks passed
@ChristianTackeGSI ChristianTackeGSI deleted the pr/geoloader branch April 1, 2024 18:19
@ChristianTackeGSI
Copy link
Member Author

Still the question, whether we should backport (fast-forward) this in 19.0?

@dennisklein
Copy link
Member

What would speak against?

@ChristianTackeGSI
Copy link
Member Author

I don't know anything. If it's a good enough fix for dev, then it should be good enough for 19.0 also.

Maybe because 19.0 is in some sort of "freeze"?
But still it's a bug fix.

@ChristianTackeGSI ChristianTackeGSI added this to the v19.0 milestone Apr 1, 2024
@ChristianTackeGSI
Copy link
Member Author

Okay, "backported" (well fast-forwarded) to 19.0.

Backport to 18.8 might be missing. I am not going to perform this anytime soon though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants