-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Multiple Leaks around FairGeoLoader #1444
Conversation
0a0dc36
to
00622d4
Compare
db58e8f
to
ddedb8f
Compare
ddedb8f
to
84e5829
Compare
84e5829
to
5a128c0
Compare
WalkthroughWalkthroughThe recent updates focus on modernizing memory management across the FairRoot project by introducing smart pointers, specifically Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
5a128c0
to
c598da4
Compare
c598da4
to
f167843
Compare
Do we want to backport this to 19.0? If no, I would postpone merging this until the release is done. |
Also some small other stylistic changes
f167843
to
a787afd
Compare
Still the question, whether we should backport (fast-forward) this in 19.0? |
What would speak against? |
I don't know anything. If it's a good enough fix for dev, then it should be good enough for 19.0 also. Maybe because 19.0 is in some sort of "freeze"? |
Okay, "backported" (well fast-forwarded) to 19.0. Backport to 18.8 might be missing. I am not going to perform this anytime soon though. |
Also some small other stylistic changes
Checklist: