Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding argo rollouts support to hack manifests #394

Merged
merged 3 commits into from
Dec 1, 2021

Conversation

tnoeding
Copy link
Contributor

Enabling feature parity with the helm chart deployment option - FairwindsOps/charts#620

Why This PR?
Support for Argo rollouts.

Fixes #
Argo rollout API access

controller.go:169]  "msg"="Error retrieving parent object" "error"="rollouts.argoproj.io is forbidden: User \"system:serviceaccount:goldilocks:goldilocks-controller\" cannot list resource \"rollouts\" in API group \"argoproj.io\" in the namespace \"namespace\""  "v1alpha1"="rollouts"
summary.go:152] no matching Workloads found for VPA/workload-name

Changes
Changes proposed in this pull request:

  • Added the controller clusterrole access to get, list, and watch for the rollouts resource
  • Added the dashboard clusterrole access to get and list for the rollouts resource

@CLAassistant
Copy link

CLAassistant commented Nov 24, 2021

CLA assistant check
All committers have signed the CLA.

@lucasreed lucasreed merged commit 6924753 into FairwindsOps:master Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants