Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(.goreleaser.yml): add sha256 check to release notes #604

Merged
merged 5 commits into from
May 30, 2023

Conversation

arthurzenika
Copy link
Contributor

@arthurzenika arthurzenika commented May 4, 2023

Improve commands so that the checksum of the downloaded file is checked before cosign is checked.

This PR fixes #

Checklist

  • I have signed the CLA
  • I have updated/added any relevant documentation

Description

What's the goal of this PR?

What changes did you make?

What alternative solution should we consider, if any?

Improve commands so that the checksum of the downloaded file is checked before cosign is checked.
@CLAassistant
Copy link

CLAassistant commented May 4, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@arthurzenika
Copy link
Contributor Author

While I'm at it (and maybe I should describe this in an issue), it would be even nicer if the generated notes would include the version, for example for the last release :

sha256sum -c goldilocks_4.7.2_checksums.txt --ignore-missing
cosign verify-blob goldilocks_4.7.2_checksums.txt --signature=goldilocks_4.7.2_checksums.txt.sig  --key https://artifacts.fairwinds.com/cosign.pub

not familiar with gorelease features though

@sudermanjr
Copy link
Member

You should be able to use the template placeholder {{.Version}} in the release note footer, looking here: https://goreleaser.com/customization/release/?h=release

.goreleaser.yml Outdated Show resolved Hide resolved
.goreleaser.yml Outdated Show resolved Hide resolved
arthurzenika and others added 3 commits May 30, 2023 13:44
Co-authored-by: Andrew Suderman <andy@suderman.dev>
Co-authored-by: Andrew Suderman <andy@suderman.dev>
@sudermanjr sudermanjr self-assigned this May 30, 2023
Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sudermanjr sudermanjr enabled auto-merge (squash) May 30, 2023 17:01
@sudermanjr sudermanjr merged commit 47bd6fc into FairwindsOps:master May 30, 2023
@sudermanjr
Copy link
Member

Latest release notes are much nicer. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants