Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to ignore some controller by Kind #710

Merged
merged 10 commits into from
Jun 24, 2024

Conversation

k11h-de
Copy link
Contributor

@k11h-de k11h-de commented Jun 13, 2024

This PR fixes #534

Checklist

  • I have signed the CLA
  • I have updated/added any relevant documentation

Description

prevent VPA creation for Cronjob or Job controller kinds

What changes did you make?

adding a new arg --ignore-controller-kind=Job,CronJob that prevents certain controller kinds from being considered

What alternative solution should we consider, if any?

notes

I am sorry that I am not following your contribution guidelines. I am not a developer and was using GitHub Copilot to make these changes. The make tidy and make build are compiling without any errors - I have only limited resources and permissions on my works laptop. I would be grateful if you would still consider this improvement.

@CLAassistant
Copy link

CLAassistant commented Jun 13, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Adding a new flag will require end-to-end tests for this flag at a minimum.

pkg/vpa/vpa.go Outdated Show resolved Hide resolved
@k11h-de k11h-de requested a review from sudermanjr June 13, 2024 16:16
Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally got a chance to look more closely at this, and there's some things that need to be corrected to match other patterns in the code where we pass settings via the reconciler.

pkg/vpa/vpa.go Outdated Show resolved Hide resolved
cmd/controller.go Show resolved Hide resolved
pkg/vpa/vpa.go Outdated Show resolved Hide resolved
pkg/vpa/vpa.go Outdated Show resolved Hide resolved
pkg/vpa/vpa.go Outdated Show resolved Hide resolved
k11h-de and others added 4 commits June 14, 2024 17:40
Co-authored-by: Andy Suderman <andy@suderman.dev>
Co-authored-by: Andy Suderman <andy@suderman.dev>
Co-authored-by: Andy Suderman <andy@suderman.dev>
Co-authored-by: Andy Suderman <andy@suderman.dev>
@k11h-de
Copy link
Contributor Author

k11h-de commented Jun 14, 2024

Hi @sudermanjr,

Thanks a lot for the suggestions. I merged them.
Please let me know if you wish any other changes.

Sorry again for my poor coding skills.
Cheers and warm wishes from Berlin
Karsten

@k11h-de k11h-de requested a review from sudermanjr June 14, 2024 15:45
cmd/controller.go Show resolved Hide resolved
@k11h-de k11h-de requested a review from sudermanjr June 22, 2024 08:10
Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks!

@sudermanjr sudermanjr merged commit d530148 into FairwindsOps:master Jun 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to ignore some controller by Kind
3 participants