Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #8: fix goreleaser version update during build #11

Merged
merged 2 commits into from Aug 13, 2020
Merged

Fix #8: fix goreleaser version update during build #11

merged 2 commits into from Aug 13, 2020

Conversation

makoscafee
Copy link
Contributor

Go release uses env variable main.version while we had main.VERSION so the version was not updated during build process. see here

@makoscafee makoscafee linked an issue Aug 11, 2020 that may be closed by this pull request
nova version shows wrong version #8
Closed
@makoscafee makoscafee merged commit dae7abd into master Aug 13, 2020
@makoscafee makoscafee deleted the bm/update-nova-version branch August 13, 2020 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbren rbren rbren approved these changes

@kimschles kimschles Awaiting requested review from kimschles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nova version shows wrong version
2 participants
@makoscafee @rbren