-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added github action to install pluto #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this!
I left a couple of inline comments. Also, I don't see the github action for test actually being run. Is there something that needs to be added for that to happen? I'm not super familiar with github actions
@sudermanjr ; pushed changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks!
Why assume podman? |
While this is nice and I appreciate the effort, it doesn't work unless you are running Podman as well. |
@funzie19 ; |
Not everybody uses public runners for a variety of reasons and private runners are not all built the same and may be missing Podman. Therefore this action wouldn't work out of the box for some users. Some sort of requirements or similar would avoid such confusion. |
I'd like to be able to use
pluto
as part of my github workflows. I did a quick google and couldn't find an action that already exists, so thought I'd contribute one.It's very simple to run and basically just copies the released
pluto
binary into the runner.