Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added github action to install pluto #225

Merged
merged 1 commit into from
Nov 10, 2021
Merged

added github action to install pluto #225

merged 1 commit into from
Nov 10, 2021

Conversation

garethahealy
Copy link
Contributor

I'd like to be able to use pluto as part of my github workflows. I did a quick google and couldn't find an action that already exists, so thought I'd contribute one.

It's very simple to run and basically just copies the released pluto binary into the runner.

@CLAassistant
Copy link

CLAassistant commented Nov 10, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

I left a couple of inline comments. Also, I don't see the github action for test actually being run. Is there something that needs to be added for that to happen? I'm not super familiar with github actions

.gitignore Outdated Show resolved Hide resolved
.github/workflows/github-action-test.yml Outdated Show resolved Hide resolved
@garethahealy
Copy link
Contributor Author

@sudermanjr ; pushed changes

Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks!

@sudermanjr sudermanjr merged commit f14af6e into FairwindsOps:master Nov 10, 2021
@miltieIV2
Copy link

Why assume podman?

@funzie19
Copy link

While this is nice and I appreciate the effort, it doesn't work unless you are running Podman as well.

@garethahealy
Copy link
Contributor Author

@funzie19 ; podman is included in ubuntu-latest which is the default github action base, so not sure what you mean by "doesn't work unless you are running Podman"

@funzie19
Copy link

@funzie19 ; podman is included in ubuntu-latest which is the default github action base, so not sure what you mean by "doesn't work unless you are running Podman"

Not everybody uses public runners for a variety of reasons and private runners are not all built the same and may be missing Podman. Therefore this action wouldn't work out of the box for some users.

Some sort of requirements or similar would avoid such confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants