Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zero-state #341

Merged
merged 3 commits into from Jun 10, 2020
Merged

fix zero-state #341

merged 3 commits into from Jun 10, 2020

Conversation

rbren
Copy link
Member

@rbren rbren commented Jun 10, 2020

No description provided.

@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #341 into master will decrease coverage by 0.01%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
- Coverage   52.14%   52.13%   -0.02%     
==========================================
  Files          12       12              
  Lines         698      702       +4     
==========================================
+ Hits          364      366       +2     
- Misses        287      288       +1     
- Partials       47       48       +1     
Impacted Files Coverage Δ
pkg/config/config.go 60.52% <60.00%> (-1.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf6e415...c461d7f. Read the comment docs.

Copy link
Contributor

@makoscafee makoscafee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbren rbren merged commit 3e9c270 into master Jun 10, 2020
@rbren rbren deleted the rb/zero-state branch June 10, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants