throw error when severity isn't set for custom check #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbren
requested review from
baderbuddy,
jordandoig and
makoscafee
as code owners
Codecov Report
@@ Coverage Diff @@
## master #360 +/- ##
==========================================
+ Coverage 53.52% 53.65% +0.12%
==========================================
Files 12 12
Lines 723 725 +2
==========================================
+ Hits 387 389 +2
Misses 283 283
Partials 53 53
Continue to review full report at Codecov.
|
makoscafee
approved these changes
Jun 22, 2020
|
I would rather show a warning instead of error and return. This would allow to comment out a custom check without the need to remove/comment out the whole custom check definition as well. Only for the convince. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.