Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement namespace support for exceptions #421

Merged
merged 4 commits into from
Oct 19, 2020

Conversation

mblaschke
Copy link
Contributor

Add namespace support for exceptions for shared clusters.

Signed-off-by: Markus Blaschke <mblaschke82@gmail.com>
@CLAassistant
Copy link

CLAassistant commented Sep 28, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@rbren rbren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, and thanks for adding a test! Just one little note

pkg/config/exemptions.go Outdated Show resolved Hide resolved
@rbren
Copy link
Member

rbren commented Sep 28, 2020

Can you also add documentation here: https://github.com/FairwindsOps/polaris/blob/master/docs/usage.md#exemptions

Signed-off-by: Markus Blaschke <mblaschke82@gmail.com>
Signed-off-by: Markus Blaschke <mblaschke82@gmail.com>
@mblaschke
Copy link
Contributor Author

Done

@marcemv90
Copy link

With this new feature is it possible to ignore completely a namespace? Because I would like to get rid of the kube-system namespace in the dashboard.

Copy link
Contributor

@baderbuddy baderbuddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good to me! Thank you!

@baderbuddy
Copy link
Contributor

@marcemv90 this should allow all controllers within a namespace to be exempted (since it matches on prefix you could add a controller-name of "") but you'd have to specify the rules to exempt still

@baderbuddy baderbuddy merged commit 5bce1db into FairwindsOps:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants