Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set full object ObjectMeta on new workload from Pod #471

Merged
merged 7 commits into from Feb 26, 2021

Conversation

jordandoig
Copy link
Contributor

No description provided.

@baderbuddy
Copy link
Contributor

This looks fantastic to me. Did you test it out and see it working by chance?

Copy link
Member

@rbren rbren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baderbuddy @jordandoig any idea how we can test that it works? Is it possible to add a test to our webhook e2e tests?

@baderbuddy
Copy link
Contributor

Oh @rbren that's a fantastic idea. I think if we add a test that looks like a failing test but with the annotations to exempt the issues then it should exercise this quite nicely.

@codecov
Copy link

codecov bot commented Jan 14, 2021

Codecov Report

Merging #471 (fb6e91a) into master (7f1c143) will increase coverage by 0.20%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #471      +/-   ##
==========================================
+ Coverage   48.49%   48.70%   +0.20%     
==========================================
  Files          14       14              
  Lines         765      772       +7     
==========================================
+ Hits          371      376       +5     
- Misses        323      325       +2     
  Partials       71       71              
Impacted Files Coverage Δ
pkg/validator/controller.go 68.18% <ø> (-5.90%) ⬇️
pkg/kube/workload.go 43.88% <40.00%> (-0.31%) ⬇️
pkg/validator/schema.go 75.00% <100.00%> (+4.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16ffe1e...fb6e91a. Read the comment docs.

@rbren rbren force-pushed the jd/admission-controller-validation-fix branch from 4a6f4e9 to cbc6bb2 Compare February 26, 2021 13:07
@rbren rbren force-pushed the jd/admission-controller-validation-fix branch from d12c94f to fb6e91a Compare February 26, 2021 15:32
@rbren rbren merged commit 4c3d0e0 into master Feb 26, 2021
@rbren rbren deleted the jd/admission-controller-validation-fix branch February 26, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants