New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set full object ObjectMeta on new workload from Pod #471
Conversation
This looks fantastic to me. Did you test it out and see it working by chance? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@baderbuddy @jordandoig any idea how we can test that it works? Is it possible to add a test to our webhook e2e tests?
Oh @rbren that's a fantastic idea. I think if we add a test that looks like a failing test but with the annotations to exempt the issues then it should exercise this quite nicely. |
Codecov Report
@@ Coverage Diff @@
## master #471 +/- ##
==========================================
+ Coverage 48.49% 48.70% +0.20%
==========================================
Files 14 14
Lines 765 772 +7
==========================================
+ Hits 371 376 +5
- Misses 323 325 +2
Partials 71 71
Continue to review full report at Codecov.
|
4a6f4e9
to
cbc6bb2
Compare
d12c94f
to
fb6e91a
Compare
No description provided.