Make it easier to run webhook tests locally #476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbren
requested review from
baderbuddy,
jordandoig and
makoscafee
as code owners
rbren
force-pushed
the
rb/webhook-tests
branch
from
74eb138
to
cd88708
Compare
Codecov Report
@@ Coverage Diff @@
## master #476 +/- ##
=======================================
Coverage 48.80% 48.80%
=======================================
Files 13 13
Lines 754 754
=======================================
Hits 368 368
Misses 317 317
Partials 69 69 Continue to review full report at Codecov.
|
jordandoig
reviewed
Jan 15, 2021
docs-md/contributing.md
Outdated
| ```bash | ||
| kind create cluster --wait=90s --image kindest/node:v1.15.11 --name polaris-test | ||
| docker build -t quay.io/fairwinds/polaris:debug . | ||
| docker push quay.io/fairwinds/polaris:debug . |
There was a problem hiding this comment.
I'm not sure the . on the end is necessary, I get "docker push" requires exactly 1 argument. when I run this
jordandoig
reviewed
Jan 15, 2021
docs-md/contributing.md
Outdated
| docker build -t quay.io/fairwinds/polaris:debug . | ||
| docker push quay.io/fairwinds/polaris:debug . | ||
| helm repo add jetstack https://charts.jetstack.io | ||
| helm install cert-manager jetstack/cert-manager --namespace cert-manager --version 0.16.1 --set "installCRDs=true" --wait |
There was a problem hiding this comment.
Mind adding kubectl create ns cert-manager above this line as well?
jordandoig
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You should now be able to use the included instructions to test the webhook locally.