Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit- Only show the failed test if flag is specified. #487

Merged
merged 5 commits into from Feb 26, 2021

Conversation

makoscafee
Copy link
Contributor

Fixes #433

@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #487 (7f1c143) into master (dea7143) will decrease coverage by 0.30%.
The diff coverage is 9.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #487      +/-   ##
==========================================
- Coverage   48.80%   48.49%   -0.31%     
==========================================
  Files          13       14       +1     
  Lines         754      765      +11     
==========================================
+ Hits          368      371       +3     
- Misses        317      323       +6     
- Partials       69       71       +2     
Impacted Files Coverage Δ
pkg/validator/output.go 0.00% <0.00%> (ø)
pkg/validator/fullaudit.go 50.00% <33.33%> (-1.17%) ⬇️
pkg/validator/summary.go 45.12% <0.00%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dea7143...7f1c143. Read the comment docs.

pkg/validator/output.go Outdated Show resolved Hide resolved
@rbren
Copy link
Member

rbren commented Feb 22, 2021

Thanks Barnie! LGTM - can you just document the flag in docs/infrastructure-as-code.md?

Copy link
Member

@rbren rbren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docs!

@makoscafee makoscafee merged commit 16ffe1e into master Feb 26, 2021
@makoscafee makoscafee deleted the only-failed-test-audit branch February 26, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outputting only failed tests
2 participants