Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version, add docs, fix up dashboard #595

Merged
merged 4 commits into from
Aug 18, 2021
Merged

bump version, add docs, fix up dashboard #595

merged 4 commits into from
Aug 18, 2021

Conversation

rbren
Copy link
Member

@rbren rbren commented Jul 27, 2021

No description provided.

@rbren rbren requested a review from makoscafee as a code owner July 27, 2021 14:46
Copy link
Contributor

@makoscafee makoscafee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good... but the namespace check does not mention the namespaces that do not have that resources.

@rbren
Copy link
Member Author

rbren commented Jul 27, 2021

Sorry Barnie, not sure I understand - can you elaborate?

@makoscafee
Copy link
Contributor

makoscafee commented Jul 27, 2021

Sorry Barnie, not sure I understand - can you elaborate?

So say you are looking for monitoring configuration in each namespace ... meaning if the namespace does not have monitoring configuration and is not in exempted namespace list the check should fail. So say two namespaces do not have monitoring configuration ... in the results you will see two failure but in the details of each failure you wont see exact namespace missing configuration, namespace value is ""

@rbren
Copy link
Member Author

rbren commented Aug 18, 2021

Here's what it looks like @makoscafee
Screen Shot 2021-08-18 at 2 52 04 PM

@rbren rbren merged commit 9ae4f77 into master Aug 18, 2021
@rbren rbren deleted the rb/update-version-2 branch August 18, 2021 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants