Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

e2e tests for multiple versions of kube #71

Merged
merged 4 commits into from Mar 6, 2020
Merged

e2e tests for multiple versions of kube #71

merged 4 commits into from Mar 6, 2020

Conversation

lucasreed
Copy link
Contributor

@lucasreed lucasreed commented Mar 6, 2020 •
edited

I realize now that by squashing down to a single commit I lost @kimschles contributions to this branch. Sorry about that and thanks for helping with this @kimschles !

sudermanjr
sudermanjr reviewed Mar 6, 2020
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
sudermanjr
sudermanjr reviewed Mar 6, 2020
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
sudermanjr
sudermanjr requested changes Mar 6, 2020
View reviewed changes
Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple little things inline.

Also, since it is only one test right now, it would be really easy to move to Venom for these. Not a requirement of this PR or a blocker at all, just wanted to point that out.

@codecov
Copy link

codecov bot commented Mar 6, 2020 •
edited

Codecov Report

Merging #71 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #71   +/-   ##
=======================================
  Coverage   39.19%   39.19%           
=======================================
  Files           4        4           
  Lines         199      199           
=======================================
  Hits           78       78           
  Misses        112      112           
  Partials        9        9

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16452ab...2eb253c. Read the comment docs.

sudermanjr
sudermanjr reviewed Mar 6, 2020
View reviewed changes
.circleci/config.yml Outdated Show resolved Hide resolved
sudermanjr
sudermanjr approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@sudermanjr sudermanjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit inline. Otherwise looks great. Thanks!

kimschles
kimschles approved these changes Mar 6, 2020
View reviewed changes
Copy link

@kimschles kimschles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw the passing tests in circle. 🎉

@lucasreed lucasreed merged commit 50d8ef7 into master Mar 6, 2020
@lucasreed lucasreed deleted the e2e_tests branch March 6, 2020 17:10
@lucasreed lucasreed mentioned this pull request Mar 6, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudermanjr sudermanjr sudermanjr approved these changes

@kimschles kimschles kimschles approved these changes

@robscott robscott Awaiting requested review from robscott

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucasreed @sudermanjr @kimschles