Refactoring go version and many fixes for e2e tests #530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudermanjr
requested changes
Feb 28, 2022
end_to_end_testing/course_files/05_test_exit_on_post_install_hook.yml
Outdated
Show resolved
Hide resolved
sudermanjr
requested changes
Feb 28, 2022
Co-authored-by: Andrew Suderman <andrew@sudermanjr.com>
lucasreed
commented
Feb 28, 2022
|
|
||
| "github.com/fairwindsops/reckoner/pkg/course" | ||
| "github.com/fatih/color" | ||
| "github.com/thoas/go-funk" | ||
| ) | ||
|
|
||
| // Plot actually plots the releases | ||
| func (c Client) Plot() error { | ||
| func (c *Client) Plot() error { |
There was a problem hiding this comment.
Confirm why this was changed.
There was a problem hiding this comment.
I changed this because c.Continue() uses a pointer to a client object. It doesn't seem to be a syntax error if we change it back to a non-pointer but I'm not really sure the repercussions.
There was a problem hiding this comment.
Technically, it only needs to be a pointer if you're going to modify it inside the function. I've seen a general convention to just make a it a pointer though, so it's probably fine?
|
Kudos, SonarCloud Quality Gate passed!
|
sudermanjr
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
What's the goal of this PR?
To fix most e2e tests for the go rewrite by adding the git repository
management feature and fixing some bugs that were uncovered by these
tests.
Also removed all python testing from the circleci config and temporarily
commented out the release workflow until we are ready to release the go
version.
What changes did you make?
What alternative solution should we consider, if any?