[go] import command implemented #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudermanjr
approved these changes
Mar 17, 2022
| releaseOut.Values = userValues | ||
| releaseOut.Repository = repository | ||
|
|
||
| // in order to set indent to 2 spaces we need to use a yaml encoder instead of yaml.Marshal |
There was a problem hiding this comment.
I thought this was fixed in Yaml v3 in the later versions?
There was a problem hiding this comment.
It still seems to default to 4 spaces in my testing and I didn't see a way to change it in the library without opting for the encoder route. I can go look again.
Comment on lines
+106
to
+109
| if len(splitChartVersion) < 2 { | ||
| return fmt.Errorf("could not parse chart version from %s - expected at least one hyphen between chart name and version", i.Chart) | ||
| } | ||
| splitPoint := len(splitChartVersion) - 1 |
There was a problem hiding this comment.
They made this annoying to get, didn't they?
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #526
Checklist
Description
What's the goal of this PR?
Added
reckoner importfunctionality. I made the decision that thisoutput will always be in v2 schema format since we shouldn't support the
old style once the go version is released. That information is printed
as a warning when
importis run.