Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

udpate CI for cross-arch docker, release candidates #555

Merged
merged 7 commits into from
Mar 29, 2022

Conversation

sudermanjr
Copy link
Member

@sudermanjr sudermanjr commented Mar 29, 2022

This PR fixes #531

Checklist

  • I have signed the CLA
  • I have updated/added any relevant documentation

Description

What's the goal of this PR?

Update CI to our standards.

What changes did you make?

  • Replace original Dockerfile with the Dockerfile-go and remove Dockerfile-go
  • Update .goreleaser.yml to include prereleases, cross-arch builds, and signing
  • Update circleci to account for all of this.
  • Push images to gcr instead of quay
  • remove the go- from the docker tags in gcr

NOTE:

I used a different regex for the release steps. I think we shouldn't be publishing docs on release candidates, so I filtered them out. We run goreleaser on all valid vx.x.x tags.

What alternative solution should we consider, if any?

n/a

Copy link
Contributor

@lucasreed lucasreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Mar 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sudermanjr sudermanjr merged commit 439e4eb into master Mar 29, 2022
@sudermanjr sudermanjr deleted the sudermanjr/update-ci branch March 29, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chore: In ci/cd enable release candidate builds
2 participants