Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to the env var escaping #566

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Conversation

sudermanjr
Copy link
Member

Checklist

  • I have signed the CLA
  • I have updated/added any relevant documentation

Description

What's the goal of this PR?

Previous logic put the $$ back, rather than replacing it with a single $

What changes did you make?

One character removed in the output of the check, and fixed the test.

What alternative solution should we consider, if any?

@sonarcloud
Copy link

sonarcloud bot commented Apr 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@lucasreed lucasreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it when it's a simple fix! 🎉

@sudermanjr sudermanjr merged commit a163b28 into master Apr 8, 2022
@sudermanjr sudermanjr deleted the sudermanjr/fix-escaping-env-vars branch April 8, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants