make shell test work universally (hopefully) #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What's the goal of this PR?
make the tests for shells work universally. they were failing on some Ubuntu-based distros at the least.
What changes did you make?
The original test just made sure the result of
newShellExecutor()matched an object hardcoded inTest_newShellExecutor().Now we independently test the attributes of the resulting object against what we want from the test, using a regex to test
got.Executableand EqualValues forgot.Args, respectively.What alternative solution should we consider, if any?
We talked about supporting a list of possible places to expect
echoon a distribution, but what if the system configuration is valid and functional, but we didn't include support? Ultimately we decided to go with a regex so we likely won't have to look at this again for a long, long time.