Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub API Limits #55

Closed
thw26 opened this issue Feb 9, 2024 · 0 comments · Fixed by #63
Closed

GitHub API Limits #55

thw26 opened this issue Feb 9, 2024 · 0 comments · Fixed by #63
Labels
github This issue is related to our use of GitHub

Comments

@thw26
Copy link
Collaborator

thw26 commented Feb 9, 2024

GitHub has a 60 request per hour limit per IP with its unauthenticated Rest API. This limit was reached during testing. This in general shouldn't be an issue for an average user. Should we account for this? Can we catch this easily? Do we add the ability to authenticate a user's API requests, i.e., add GitHub oauth2 support, if desired?
@thw26 thw26 added the github This issue is related to our use of GitHub label Feb 9, 2024
thw26 pushed a commit that referenced this issue Feb 20, 2024
Fix code for update to latest appimage.
d9c3594 
Make net_get() more robust.

Fix #55. Get latest_release_url now accounts for the GitHub API limit.

Other small fixes and debugging lines.
@thw26 thw26 linked a pull request Feb 20, 2024 that will close this issue
Add Update To Latest AppImage Option #63
Merged
thw26 pushed a commit that referenced this issue Feb 21, 2024
Fix #5. Add update_to_latest_recommended_appimage.
ed70446 
Make net_get() more robust.

Fix #55. Get net_get now accounts for the GitHub API limit.

Other small fixes and debugging lines.
thw26 pushed a commit that referenced this issue Feb 22, 2024
Fix #5. Add update_to_latest_recommended_appimage.
ae8231a 
Make net_get() more robust.

Fix #55. Get net_get now accounts for the GitHub API limit.

Other small fixes and debugging lines.
thw26 pushed a commit that referenced this issue Feb 24, 2024
Fix #5. Add update_to_latest_recommended_appimage.
b7d737d 
Make net_get() more robust.

Fix #55. Get net_get now accounts for the GitHub API limit.

Other small fixes and debugging lines.
thw26 pushed a commit that referenced this issue Feb 24, 2024
Fix #5. Add update_to_latest_recommended_appimage.
08d114d 
Make net_get() more robust.

Fix #55. Get net_get now accounts for the GitHub API limit.

Other small fixes and debugging lines.
thw26 pushed a commit that referenced this issue Feb 24, 2024
Fix #5. Add update_to_latest_recommended_appimage.
810d0c5 
Make net_get() more robust.

Fix #55. Get net_get now accounts for the GitHub API limit.

Other small fixes and debugging lines.
@thw26 thw26 closed this as completed in a8e3812 Feb 25, 2024
@thw26 thw26 closed this as completed in #63 Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
github This issue is related to our use of GitHub
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Update To Latest AppImage Option FaithLife-Community/LogosLinuxInstaller
1 participant
@thw26