Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modded - AI crew stuck attempting to load welding fuel into modded repairtools #5190

Closed
Ek-Videogames opened this issue Mar 7, 2021 · 5 comments
Labels
Bug Something isn't working Code Programming task Low prio An issue that doesn't cause problems with the gameplay or is not important to fix for some reason Modding Modding-related feature request or issue, or a bug that only occurs with mods Needs testing Issue might be resolved, but needs to be verified by testing.

Comments

@Ek-Videogames
Copy link

Ek-Videogames commented Mar 7, 2021

When given a modded repair tool that uses a non-weldingtank as its fuel item and then ordered to repair leaks, bots will become stuck trying to find the nearest welding fuel tank and continuing to pick it up and then fail to place it into the repair tool. Bots do seem to be able to correctly identify valid tools by their tags, but do not seem to take any consideration for any tool that does not have containment & item-requirement for anything other than welding fuel.

Edit:
There does not seem to be a 'universal' tag for repair tools either, or if there is bots do not recognize it when deciding where to find tools.

@Regalis11 Regalis11 added Bug Something isn't working Code Programming task Modding Modding-related feature request or issue, or a bug that only occurs with mods labels Mar 7, 2021
@Regalis11
Copy link
Collaborator

You need to have the tag "weldingfuel" in the fuel item. Tested this with a custom item repair tool and it seems to be working as intended, moving to QA

@Regalis11 Regalis11 added Needs testing Issue might be resolved, but needs to be verified by testing. Low prio An issue that doesn't cause problems with the gameplay or is not important to fix for some reason labels Apr 13, 2021
@itchyOwl
Copy link
Collaborator

The "universal" tag for welding tool is "weldingequipment". Use that for custom welding tools. And if you use a custom fuel, use "weldingfuel", like Regalis said.

Note that the "RepairTool" component is used for both welding tool and plasma cutter. It's not actually used for repairing anymore, like it used to be.

@Rokvach
Copy link
Collaborator

Rokvach commented Apr 14, 2021

Closing

@Rokvach Rokvach closed this as completed Apr 14, 2021
@Ek-Videogames
Copy link
Author

You need to have the tag "weldingfuel" in the fuel item. Tested this with a custom item repair tool and it seems to be working as intended, moving to QA

However "weldingfuel" is not its own tag, it is just the same as the item ID used by welding fuel. The issue this presents is it allows bots (and players) to put wrong fuel types into vanilla welding tool .
Due to <Containable items="weldingfuel,oxygensource" />

Ex.
image

@itchyOwl
Copy link
Collaborator

You need to have the tag "weldingfuel" in the fuel item. Tested this with a custom item repair tool and it seems to be working as intended, moving to QA

However "weldingfuel" is not its own tag, it is just the same as the item ID used by welding fuel. The issue this presents is it allows bots (and players) to put wrong fuel types into vanilla welding tool .
Due to <Containable items="weldingfuel,oxygensource" />

That's not true: "weldingfuel" is tag used by referencing any kind of welding fuel. The identifier of the vanilla welding fuel tank is "weldingfueltank". It's possible that there's still references using identifiers where we should use tags in some placecs, but I don't see that's the case here:
image

However, if you are referring to #5527, it should now be fixed by separating "weldingfuel" and "weldingtoolfuel".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Code Programming task Low prio An issue that doesn't cause problems with the gameplay or is not important to fix for some reason Modding Modding-related feature request or issue, or a bug that only occurs with mods Needs testing Issue might be resolved, but needs to be verified by testing.
Projects
None yet
Development

No branches or pull requests

4 participants